Hello Bollini, Thank you for your input! Yes I am aware of that, as mentioned in my other thread regarding this issue:
https://groups.google.com/forum/#!searchin/dspace-tech/cleanup$20not$20working%7Csort:relevance/dspace-tech/gz73RSg4Fhs/736BHQhmBgAJ The following is my understanding of the code: The cleanup command runs the cleanup function in BitstreamStorageServiceImpl.java: https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/storage/bitstore/BitstreamStorageServiceImpl.java#L220 However, it will only actually call the remove() method in line 291: https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/storage/bitstore/BitstreamStorageServiceImpl.java#L291 Which needs *bitstreamService.findDuplicateInternalIdentifier(context, bitstream).size() to return* > 0 and it never will. It always returns 0 and thus never actually calls the remove() method. It will never return > 0 because the function *findDuplicateInternalIdentifier* is just a validation for versioning and should only return > 0 if theres more than one bitstream ID for a given bitstream internal ID, as seen: https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/dao/impl/BitstreamDAOImpl.java#L51 The above is my interpretation of the code and the point where I'm stuck at the moment. Note that I can't get it to work in local standard storage as well. Using DSpace 6.0. Thanks, Pedro Amorim quarta-feira, 18 de Janeiro de 2017 às 11:35:45 UTC-1, Bollini Andrea escreveu: > > Hi Pedro, > > I could say something obvious but just to check: > > are you aware that a deletion from the UI is just a "promise"? the > bitstream row is flagged with deleted = true, the real deletion is > performed by the cleanup script > > i.e. [dspace-dir]/bin/dspace cleanup > > > https://github.com/DSpace/DSpace/blob/ea642d6c9289d96b37b5de3bb7a4863ec48eaa9c/dspace/config/launcher.xml#L37 > > > https://github.com/DSpace/DSpace/blob/269af71afb602808a14edf822ad658c3895e0a37/dspace-api/src/main/java/org/dspace/storage/bitstore/Cleanup.java > > Best, > > Andrea > > Il 18/01/2017 13:08, Pedro Amorim ha scritto: > > Hello Jaime, > > Did you come to any conclusion? > i'm having the same problem but with Google Cloud Storage and also local > standard storage. You can follow the thread here: > > https://groups.google.com/forum/#!searchin/dspace-tech/cleanup$20not$20working%7Csort:relevance/dspace-tech/gz73RSg4Fhs/736BHQhmBgAJ > > Thanks, > > Pedro Amorim > > quarta-feira, 11 de Janeiro de 2017 às 20:00:04 UTC-1, Jaime Solorzano > escreveu: >> >> >> >> I was watching this but it does not >> >> >> https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/storage/bitstore/S3BitStoreService.java#L247 >> >> >> Jaime >> >> >> El miércoles, 11 de enero de 2017, 11:59:27 (UTC-5), Jaime Solorzano >> escribió: >>> >>> Hello >>> >>> I see that cleanup does not delete the s3 files, which method should be >>> used? >>> >>> Someone done this? >>> >>> >>> Jaime Solorzano >>> >> -- > You received this message because you are subscribed to the Google Groups > "DSpace Technical Support" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at https://groups.google.com/group/dspace-tech. > For more options, visit https://groups.google.com/d/optout. > > > -- > Andrea Bollini > Chief Technology and Innovation Officer > > 4Science, www.4science.it > office: Via Edoardo D'Onofrio 304, 00155 Roma, Italy > mobile: +39 333 934 1808 > skype: a.bollini > linkedin: andreabollini > orcid: 0000-0002-9029-1854 > > an Itway Group Company > Italy, France, Spain, Portugal, Greece, Turkey, Lebanon, Qatar, U.A.Emirates > > -- You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/dspace-tech. For more options, visit https://groups.google.com/d/optout.
