Hi Paul,
Very belated reply to this but thought I might as well chip in since I i
just encountered the same problem! ;)
The problem is that classes in org.dspace.app.webui.jsptag use jsp-api as
well as servlet-api, but jsp-api isn't included as a dependency in the
pom.xml for the jspui overlay.
So to fix this, you just need to edit
[dspace-src]/dspace/modules/jspui/pom.xml and add this to the list of
dependencies at the bottom, underneath the servlet-api dependency:
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>jsp-api</artifactId>
<scope>provided</scope>
<version>2.0</version>
</dependency>
Hope this helps, even if it has been over a year! I might consider
proposing this be added to the default pom.xml as editing ItemTag, etc.,
would be a quite common and reasonable customisation for most people, I'd
think...
Cheers
Kim
On Tuesday, 12 September 2017 22:28:48 UTC+12, Paul Warner wrote:
>
> Hello Claudia,
>
> Thanks very much for your reply! Your link saved me - I had forgotten
> that there are two levels for the "mvn package" command: dspace-src and
> dspace-src/dspace. The first gives you a full build, and the second a
> quick build. I was always using the quick build option, not realizing that
> it would not recompile my java files. The full build option, running mvn
> package from dspace-src, was the answer.
>
> I tried using the overlay, but setting a java file in an empty directory
> tree created problems for the compiler:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile
> (default-compile) on project jspui: Compilation failure: Compilation
> failure:
> [ERROR]
> /opt/dspace/dspace-6.1-src-hfmdk/dspace/modules/jspui/src/main/java/org/dspace/app/webui/jsptag/ItemTag.java:[24,25]
>
> package javax.servlet.jsp does not exist
> [ERROR]
> /opt/dspace/dspace-6.1-src-hfmdk/dspace/modules/jspui/src/main/java/org/dspace/app/webui/jsptag/ItemTag.java:[25,25]
>
> package javax.servlet.jsp does not exist
> [ERROR]
> /opt/dspace/dspace-6.1-src-hfmdk/dspace/modules/jspui/src/main/java/org/dspace/app/webui/jsptag/ItemTag.java:[27,32]
>
> package javax.servlet.jsp.tagext does not exist
> [ERROR]
> /opt/dspace/dspace-6.1-src-hfmdk/dspace/modules/jspui/src/main/java/org/dspace/app/webui/jsptag/ItemTag.java:[199,30]
>
> cannot find symbol
>
> etc.
>
> The overlay option seems to be for jsp files and configuration files,
> which I am using. Is that correct?
>
> Best regards,
> Paul
>
> On Tuesday, September 12, 2017 at 10:24:57 AM UTC+2, Claudia Jürgen wrote:
>>
>> Hello Paul,
>>
>> did you alsready make an overlay at some point, i.e. copying the file to
>> [dspace-source]/dspace/modules/addditions ...
>> as described in
>> https://wiki.duraspace.org/display/DSDOC6x/Advanced+Customisation
>> There you should do your customizations.
>> And this will be used, if present, and not the dspace-jspui/src/main ...
>> one.
>>
>> Hope this helps
>>
>> Claudia Jürgen
>>
>>
>>
>> Am 12.09.2017 um 10:01 schrieb Paul Warner:
>> > Dear Support,
>> >
>> > I need to make some small changes to the way an item is displayed, and
>> I
>> > have
>> > edited
>> dspace-jspui/src/main/java/org/dspace/app/webui/jsptag/ItemTag.java.
>> > I ran mvn package, and ant update, and copied the files into Tomcat.
>> But
>> > none of my changes are appearing. Why not?
>> >
>> > Thanks,
>> > Paul
>> >
>>
>> --
>> Claudia Juergen
>> Eldorado
>>
>> Technische Universität Dortmund
>> Universitätsbibliothek
>> Vogelpothsweg 76
>> 44227 Dortmund
>>
>> Tel.: +49 231-755 40 43
>> Fax: +49 231-755 40 32
>> [email protected]
>> www.ub.tu-dortmund.de
>>
>> Wichtiger Hinweis: Die Information in dieser E-Mail ist vertraulich. Sie
>> ist ausschließlich für den Adressaten bestimmt. Sollten Sie nicht der für
>> diese E-Mail bestimmte Adressat sein, unterrichten Sie bitte den Absender
>> und vernichten Sie diese Mail. Vielen Dank.
>> Unbeschadet der Korrespondenz per E-Mail, sind unsere Erklärungen
>> ausschließlich final rechtsverbindlich, wenn sie in herkömmlicher
>> Schriftform (mit eigenhändiger Unterschrift) oder durch Übermittlung eines
>> solchen Schriftstücks per Telefax erfolgen.
>>
>> Important note: The information included in this e-mail is confidential.
>> It is solely intended for the recipient. If you are not the intended
>> recipient of this e-mail please contact the sender and delete this message.
>> Thank you. Without prejudice of e-mail correspondence, our statements are
>> only legally binding when they are made in the conventional written form
>> (with personal signature) or when such documents are sent by fax.
>>
>
--
All messages to this mailing list should adhere to the DuraSpace Code of
Conduct: https://duraspace.org/about/policies/code-of-conduct/
---
You received this message because you are subscribed to the Google Groups
"DSpace Technical Support" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/dspace-tech.
For more options, visit https://groups.google.com/d/optout.
