Hello,
I am currently updating our DSpace from 1.3.2 to 1.4.2
which BTW turns out to be a tremendous task given that
our former coder decided to juggle around code at will.
I stumbled across this code fragment which is still in
the current code:
/trunk/dspace-jspui/src/main/webapp/feedback/form.jsp
74 String fromPage = request.getParameter("fromPage");
75 if (fromPage == null)
76 {
77 fromPage = "";
78 }
I believe that it is not in use any more and should be
removed without further ado. Am I wrong? I think it did
not work properly even back in 1.3.2 and was already
replaced by the same line in FeedbackServlet.java:
String fromPage = request.getParameter("fromPage");
This has been further spiced up for spam avoidance mean-
while (thanks). If my understanding of the code is alright,
the old solution relied on passing the originating page of
the feedback request by URL. The Feedback link has moved
throughout our Site from footer to header to navbar where
it is placed right now. The code fragment containing the
frompage variable has left detritus in all of these files.
I have commented out every instance I found in JSPs and
everything still works fine for me. But I may be wrong and
it still acts from some file I have not visited yet. This
is why I am not completely sure when saying that its ob-
solete.
If the gurus would decide to remove it from trunk, I would
feel comfortable to do a search all over our current code
and remove it from every JSP file where I can find it.
Thanks, Christian
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
