Hi Stuart, well ... I think it is better to put the 'toLowerCase' in the corresponding Authentication-java Files.
I plan to use the netid for the Shibboleth-login as a persistent identifier and this is case sensitiv. I will add this to the bug tracker as soon as possible. Merry Christmas Jochen Stuart Lewis schrieb: > Hi Jochen, > > >> I detected, that in EPerson.java the netid is manipulated and changed to >> lower case. >> I think this is not good! >> >> There are some problems: >> - The netid is no longer unique, because U0815 and u0815 will get the >> same netid. >> > > AFAIK most LDAP fields (except e.g. password) are case-insensitive, so this > shouldn't pose a problem. > > >> - In the findByNetid method there is NO change to lower case, so it can >> not be found. >> > > LDAPAuthentication.java and LDAPHierarchicalAuthentication.java both use > "netid.toLowerCase()" when using the findByNetid method, so that is OK. > However RegisterServlet.java does not - so this probably needs addressing. I > suspect that this hasn't been discovered so far as probably most sites using > LDAP have LDAP auto registration turned on. > > It would be good if you could report this in the bug tracker so we can get > it fixed: http://sourceforge.net/tracker/?group_id=19984&atid=119984 > > Thanks, > > > Stuart > _________________________________________________________________ > > Gwasanaethau Gwybodaeth Information Services > Prifysgol Aberystwyth Aberystwyth University > > E-bost / E-mail: [email protected] > Ffon / Tel: (01970) 622860 > _________________________________________________________________ > > > ------------------------------------------------------------------------------ > _______________________________________________ > DSpace-tech mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/dspace-tech > > -- Dr. rer. nat. Jochen Lienhard UB Universität Freiburg Dezernat EDV Tel: (0761) 203-3908 Email: [email protected] ------------------------------------------------------------------------------ _______________________________________________ DSpace-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-tech
