Hi Andrea, Thanks for checking this!
I'm happy to have the chance to give something back to the dspace community (even if it's only one word). I'll submit the issue/patch today. Reinhard On Sun, Aug 1, 2010 at 9:59 AM, Andrea Bollini <[email protected]> wrote: > Hi Reinhard, > I'm the author of the buggy code, sorry :-( > I think that your fix is ok, please fire a jira issue about it and post a > patch file if possible. > > http://jira.dspace.org > > I will take care of including the fix in the code base in the next weeks. > Best, > Andrea > > > Il 28/07/2010 04:57, Reinhard Engels ha scritto: >> >> Hi fellow dspacers, >> >> We just noticed that our authority browse index was only including >> items for which the first author is recognized. A recognized author in >> any other position wasn't good enough. So a significant number of >> items that should have been in our browse index weren't. >> >> Here's the relevant dspace.cfg entry: >> >> webui.browse.index.4 = >> harvardAuthor:metadataAuthority:dc.contributor.author:authority >> >> I took a look at >> dspace-api/src/main/java/org/dspace/browse/IndexBrowse.java and it >> looks like there's a "break;" around line 450 that should be a >> "continue;" >> >> Here's the context: >> >> if (bis[i].isAuthorityIndex()&& >> (values[x].authority >> == null || values[x].confidence< minConfidence)) >> { >> // if we have an authority >> index only authored metadata will go here! >> log.debug("Skipping >> item="+item.getID()+", >> field="+values[x].schema+"."+values[x].element+"."+values[x].qualifier+", >> value="+values[x].value+", authority="+values[x].authority+", >> confidence="+values[x].confidence+" (BAD AUTHORITY)"); >> break; ////////////// >> Reinhard thinks this should be a "continue"??? >> } >> >> Changing the "break" to a "continue" makes logical sense to me insofar >> as I understand what is going on, and so far it has seemed to fix the >> problem for us. But it's in a rather complex region of code and I'm >> still a bit of a dspace newbie, so it's quite possible that this isn't >> the ideal fix (and perhaps has side effects that I haven't yet >> realized). >> >> I'm hoping perhaps a more seasoned dspace guru could take a look? >> >> Thanks in advance -- and please let me know if you need more information. >> >> Reinhard >> >> >> ------------------------------------------------------------------------------ >> The Palm PDK Hot Apps Program offers developers who use the >> Plug-In Development Kit to bring their C/C++ apps to Palm for a share >> of $1 Million in cash or HP Products. Visit us here for more details: >> http://ad.doubleclick.net/clk;226879339;13503038;l? >> http://clk.atdmt.com/CRS/go/247765532/direct/01/ >> _______________________________________________ >> DSpace-tech mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/dspace-tech >> >> > > > -- > Dott. Andrea Bollini > Project Manager, IT Architect& Systems Integrator > Sezione Servizi per le Biblioteche e l'Editoria Elettronica > CILEA, http://www.cilea.it > tel. +39 06-59292853 > cel. +39 348-8277525 > > --- > > Disclaimer: the content of this email is confidential and may be privileged, > and it must not be disclosed or copied without the sender's consent. If you > have received this message in error, please notify the sender and remove it > from your system. The content of this email does not constitute legal > advice, nor any responsibility is accepted for loss or damage incurred as a > result of acting upon its contents or attachments. > The statements and opinions expressed in this email are those of the author > and do not necessarily reflect those of the employer. > > ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm _______________________________________________ DSpace-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-tech
