Peter or Bram, Can one of you create a JIRA issue around this bug fix and schedule it for 1.7.1? I just want to make sure we get it assigned and committed into the codebase.
- Tim On 12/22/2010 6:50 AM, Bram Luyten wrote: > Thanks for the elegant fix for (1.) Peter. > > I have documented it here, awaiting this fix to be applied in the codebase: > https://wiki.duraspace.org/display/DSDOC/Mirage+Configuration+and+Customization > > Further Mirage troubleshooting information can also be added there. > > Martins, > > can you provide some more details about the errors with generating the > sitemaps ? (2.) > > to remove the feedback link, check the buildFooter template in your > lib/core/page-structure.xsl & remove the part I highlighted in bold. > > <xsl:template name="buildFooter"> > <div id="ds-footer-wrapper"> > <div id="ds-footer"> > <div id="ds-footer-left"> > <a href="http://www.dspace.org/"; target="_blank">DSpace software</a> > copyright © 2002-2010  <a > href="http://www.duraspace.org/"; target="_blank">Duraspace</a> > </div> > <div id="ds-footer-right"> > <span class="theme-by">Theme by </span> > <a title="@mire NV" target="_blank" href="http://atmire.com"; > id="ds-footer-logo-link"> > <span id="ds-footer-logo"> </span> > </a> > </div> > <div id="ds-footer-links"> > <a> > <xsl:attribute name="href"> > <xsl:value-of > > > select="/dri:document/dri:meta/dri:pageMeta/dri:metada...@element='contextPath'][not(@qualifier)]"/> > <xsl:text>/contact</xsl:text> > </xsl:attribute> > <i18n:text>xmlui.dri2xhtml.structural.contact-link</i18n:text> > </a> > <xsl:text> | </xsl:text> > *<a> > <xsl:attribute name="href"> > <xsl:value-of > > > select="/dri:document/dri:meta/dri:pageMeta/dri:metada...@element='contextPath'][not(@qualifier)]"/> > <xsl:text>/feedback</xsl:text> > </xsl:attribute> > <i18n:text>xmlui.dri2xhtml.structural.feedback-link</i18n:text> > </a>* > </div> > <!--Invisible link to HTML sitemap (for search engines) --> > <a class="hidden"> > <xsl:attribute name="href"> > <xsl:value-of > > > select="/dri:document/dri:meta/dri:pageMeta/dri:metada...@element='contextPath'][not(@qualifier)]"/> > <xsl:text>/htmlmap</xsl:text> > </xsl:attribute> > <xsl:text> </xsl:text> > </a> > </div> > </div> > </xsl:template> > > Thanks for the useful comments ! > > best regards, > > Bram Luyten > > @mire > > Technologielaan 9 - Heverlee 3001 - Belgium > 2888 Loker Avenue East, Suite 305 - Carlsbad, CA 92010 - USA > > atmire.com <http://atmire.com/> - Institutional Repository Solutions > > > On Wed, Dec 22, 2010 at 1:17 PM, Martins Purins <[email protected] > <mailto:[email protected]>> wrote: > > Hi Peter > > thanks for your helping. > According to point 4. > I have seen the RSS in source, but I know, that a lot of users don't > read page source :). Thanks for your sample. I have added a small > modification for better look :) > in Mirage/lib/xsl/core/navigation.xsl, after > <!-- Once the search box is built, the other parts of the > options are added --> > <xsl:apply-templates/> > I add this: > <!-- Prieks RSS --> > <xsl:if > > test="count(/dri:document/dri:meta/dri:pageMeta/dri:metada...@element='feed']) > != 0"> > <h1 class="ds-option-set-head"><xsl:text>RSS Feeds</xsl:text></h1> > <div id="ds-feed-option" class="ds-option-set"> > <ul><xsl:call-template name="addRSSLinks"/></ul> > </div> > </xsl:if> > > According to the point 6. > > I changed my hostname, and you where right. Feedback works, but I > still want to remove this option. The thing I don’t understand is - > how the page is generated. I commented out in Contact.java file link > to feedback but it still persists. > > And point 7 > The thing I did not describe previously. I have enabled shibboleth, > but still on some links (including "contact us") Register link > appears. > Which way would be better > a) Replace RegisterServlet.java with something who disable registration? > b) Find where Register link is generated and comment out (hard for me > :) ) Can you get some timps what I need to comment out > > Thanks > > Regards > Martins > > > > > On 21 December 2010 21:00, Peter Dietz <[email protected] > <mailto:[email protected]>> wrote: > > Hi Martins, > > Thanks for the evaluation, its important to fix these things. > > I have some comments inline. > > -- > > Peter Dietz > > Systems Developer/Engineer > > Ohio State University Libraries > > > > > > > > On Tue, Dec 21, 2010 at 10:07 AM, Martins Purins > <[email protected] <mailto:[email protected]>> wrote: > >> > >> Hello. > >> First of all thanks for new version of Dspace. I have set up > >> development environment to switch from 1.6.2 to 1.7 Mirage, but > I have > >> found some small problems. Some I can solve but some are to complex > >> for me: ) > > > > I'll take the liberty to answer the easy questions, the memory > leak question > > is too hard for me. > > > >> > >> 1. > http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js is > >> hardcoded with http. When I switch to https there is an error in > IE8. > > > > For my local setup, I use the Google CDN version of jQuery as > well, however, > > I also add another check to load https when needed to match the > site, to > > prevent from having mixed secure/unsecure content. > > Additionally as a fail-safe, I have it load a version of jQuery > served > > locally if the CDN were to have a problem. > > <!-- Grab Google CDN jQuery. fall back to local if necessary. > Also use same > > http / https as site --> > > <script type="text/javascript"> > > var JsHost = (("https:" == document.location.protocol) ? > "https://"; : > > "http://";); > > document.write(unescape("%3Cscript src='" + JsHost + > > "ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js > <http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js>' > > type='text/javascript'%3E%3C/script%3E")); > > </script> > > <script>!window.jQuery && document.write('<script > > src="/dspace/static/js/jquery-1.4.2.min.js"><\/script>')</script> > > This fix should probably make its way into the code base. > > > >> > >> 4. I cant find, how to enable RSS syndication in mirage theme? > May be > >> it is easy but still :) > >> # enable syndication feeds - links display on community and > collection > >> home pages > >> # (This setting is not used by XMLUI, as you enable feeds in > your theme) > >> webui.feed.enable = true > > > > Mirage has the syndication feeds in the source, they are in the > html head > > <link type="application/rss+xml" rel="alternate" > > href="/xmlui/feed/rss_1.0/10673/6423" /> > > <link type="application/rss+xml" rel="alternate" > > href="/xmlui/feed/rss_2.0/10673/6423" /> > > <link type="application/atom+xml" rel="alternate" > > href="/xmlui/feed/atom_1.0/10673/6423" /> > > But if you also wanted to add links to the page that said: "Click > here for > > RSS 2.0 feed". Then something like this should help. > > Create a new template. > > <xsl:template name="addRSSLinks"> > > <xsl:for-each > > > > select="/dri:document/dri:meta/dri:pageMeta/dri:metada...@element='feed']"> > > <li><a> > > <xsl:attribute name="href"> > > <xsl:value-of select="."/> > > </xsl:attribute> > > <xsl:value-of select="@qualifier"/> > > </a></li> > > </xsl:for-each> > > </xsl:template> > > > > And then in Mirage/lib/xsl/core/navigation.xsl, add this > somewhere before > > the end of dri:options > > <xsl:if > > > > test="count(/dri:document/dri:meta/dri:pageMeta/dri:metada...@element='feed']) > > != 0"> > > <h3 id="ds-feed-option-head" class="ds-option-set-head"><xsl:text>RSS > > Feeds</xsl:text></h3> > > <div id="ds-feed-option" class="ds-option-set"> > > <ul><xsl:call-template name="addRSSLinks"/></ul> > > </div> > > </xsl:if> > > > >> > >> 6. Link to feedback does not work in Mirage theme. Even in > demo.dspace.org <http://demo.dspace.org> > > > > How the refer page works should be better documented, the error > you get that > > you have a bad referrer is because it checks that the page you > came from to > > get to the feedback form came from your DSpace site, as opposed > to some link > > spammer who's hijacking your form for anonymous mailings. Meaning > that if > > you change the dspace.hostname to match your current usage, then > feedback > > page will work properly. > > In dspace.cfg: > > set dspace.hostname and dspace.baseUrl correctly. They are default to > > localhost, but on the demo server, I just set dspace.hostname = > > demo.dspace.org <http://demo.dspace.org> and now the feedback > form works properly. > > > > > ------------------------------------------------------------------------------ > Forrester recently released a report on the Return on Investment > (ROI) of > Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even > within 7 months. Over 3 million businesses have gone Google with > Google Apps: > an online email calendar, and document program that's accessible > from your > browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew > _______________________________________________ > DSpace-tech mailing list > [email protected] > <mailto:[email protected]> > https://lists.sourceforge.net/lists/listinfo/dspace-tech > > > > > ------------------------------------------------------------------------------ > Forrester recently released a report on the Return on Investment (ROI) of > Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even > within 7 months. Over 3 million businesses have gone Google with Google Apps: > an online email calendar, and document program that's accessible from your > browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew > > > > _______________________________________________ > DSpace-tech mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/dspace-tech ------------------------------------------------------------------------------ Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew _______________________________________________ DSpace-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-tech
