Hi Jessica,
I just noticed that our site has that issue as well. So.. I filed a DSpace
bug, fixed it, and added a patch to Jira, complete with screenshots of
before-and-after.
https://jira.duraspace.org/browse/DS-1044
I'll probably need some feedback from people on whether we should be
truncating the length to 50 characters or not. Either way, it shouldn't be
Java limiting this information. XSL is capable of truncating at a given
length. I've chosen not to limit at all, just have CSS keep things looking
normal though. For the patch, cheers to Josi for pulling out the 50 char
limit. And thanks to Jessica for finding the bug/annoyance.
Hej hej,
Peter Dietz
On Thu, Sep 29, 2011 at 3:16 PM, Josefina Perez Alvarez
<[email protected]>wrote:
> *Hi *Jessica Lindholm,
>
> We needed to do this change in our installation:
> Edit [dspace-src]/dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/
> app/xmlui/aspect/submission/submit/SelectCollectionStep.java
>
> In public void addBody(Body body)
>
> In
> select.addOption("",T_collection_default);
> for (Collection collection : collections)
> {
> String name = collection.getMetadata("name");
> if (name.length() > 50)
> /** changed from 50 to 100 */
> {
> name = name.substring(0, 47) + "..."; /**
> changed from 47 to 97 (minus 3 to include "...")*/
> }
> select.addOption(collection.getHandle(),name);
> }
> Button submit = list.addItem().addButton("submit");
> submit.setValue(T_submit_next);
>
> maven
> ant
> restart tomcat
>
> Hope this help,
> Josi Perez
>
>
>
>
> 2011/9/29 Jessica Lindholm <[email protected]>
>
>> Hello all,
>> this is a very specific question which answer I believe hide in one of
>> the xsl:s.
>>
>> When a user picks a collection in the submission process from the
>> dropdown list of all collections a string-length of max 50 is set
>> somewhere. I cannot find its whereabouts. Users end up trying to
>> distuingish their collection to submit to from drop down option values
>> looking like this
>>
>> <div xmlns="http://di.tamu.edu/DRI/1.0/" class="ds-form-content">
>> <select id="aspect_submission_submit_SelectCollectionStep_field_handle"
>> class="ds-select-field" name="handle" title="Select the collection you
>> wish to submit an item to.">
>> <option value="">Select a collection...</option>
>> <option value="2043/6050">Student Essays / Utbildningsvetenskap med
>> inrik...</option>
>> <option value="2043/4488">Student Essays / Utbildningsvetenskap med
>> inrik...</option>
>> <option value="2043/7087">Student Essays / Utbildningsvetenskap med
>> inrik...</option>
>>
>> which is far from optimal.
>>
>> I have looked in structural.xsl, [localtheme].xsl, dri2xhtml/*.xsl
>> without success. We have made adjustments of various max chars of
>> titles, filenames etc in the local theme, but not on collection names in
>> drop-downs at submission.The width of the dropdown list have been
>> adjusted in the css to see if that would help, but it is quite obvious a
>> string-length setting hiding somewhere. The collection names seem to be
>> shortened only in this particular display.
>>
>> We use DSpace 1.7.2 XMLUI and have built our own theme based on
>> Kubrick.xsl.
>>
>> Anyone with ideas how to solve this, rather than shortening names of
>> collections?
>>
>> Kind regards
>> Jessica Lindholm
>> --
>>
>> ________________________________________________
>> Jessica Lindholm
>>
>> Malmö högskola
>> Bibliotek och IT
>> Orkanenbiblioteket
>> 205 06 Malmö
>>
>> Malmö University
>> Library and IT Service
>> Orkanen Library
>> 205 06 Malmö
>> Sweden
>>
>> [email protected]
>> +46 (0)40 665 71 39
>> http://www.mah.se/bit
>> http://homeweb.mah.se/~bijeli/
>> http://www.linkedin.com/in/jessical
>>
>>
>> ------------------------------------------------------------------------------
>> All the data continuously generated in your IT infrastructure contains a
>> definitive record of customers, application performance, security
>> threats, fraudulent activity and more. Splunk takes this data and makes
>> sense of it. Business sense. IT sense. Common sense.
>> http://p.sf.net/sfu/splunk-d2dcopy1
>> _______________________________________________
>> DSpace-tech mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/dspace-tech
>>
>
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> _______________________________________________
> DSpace-tech mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/dspace-tech
>
>
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech