On Wed, Jun 5, 2013 at 5:40 PM, Shawn M. Kiewel <[email protected]> wrote: > I mentioned earlier that I was experiencing a broken layout while using a > customized Reference theme on DSpace 3.1 (no discovery), wherein the > ds-options div was contained within ds-body, with the misapprehension that > it had to do with the number of recent submissions. Thinking it was a > problem with my customized Reference theme, I decided that the best solution > was to move to the Mirage theme, which did not appear to have this issue. > However the Mirage theme caused instability in my installation (never > figured out why), so I was forced back to the Reference theme since I was in > a production down situation. I decided it would be easier to start fresh > than to find and fix the bug in the previous customized theme, so I went > about customizing a fresh copy of Reference. However, I soon found out that > the bug persisted in my new theme, so I reverted to a stock Reference theme > and discovered that the bug was still present. This lead me to messing > around with the collection metadata to see if I could find out what was > different from those that worked, and to see if I could find a workaround. > And I succeeded. > > It turns out the problematic fields are a combination of the license field > and the copyright field. If both fields are blank or both fields have a > value, everything works just fine. However, if there is something in the > license field, but nothing in the copyright field, things break. Looking at > the source of the page while broken, it's clear that the problem is the > .detail-view-rights-and-license div that is being self closed when there is > no copyright information, resulting in <div > class="detail-view-rights-and-license" />. Self-closing divs are not valid > xhtml, so the browsers are not closing the div properly, resulting in all > content being subsumed by the ds-body div. > > I have been unable to determine how exactly that div is being created as > yet, so I haven't got a real fix for the problem, but I did come up with a > workaround: ensure that those collections with license info have something > (anything, really) in the copyright field, and then I hide the div with css. > This preserves the layout and license, while not cluttering up the page with > an undesired copyright message.
Hi Shawn, thanks for the analysis and letting us know. Please, file a Jira bug for this so that we don't forget to look at it. Thanks again. Regards, ~~helix84 Compulsory reading: DSpace Mailing List Etiquette https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ DSpace-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-tech List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette
