On Mon, Jul 29, 2013 at 11:31 PM, Keir Vaughan-Taylor <[email protected]> wrote:
> Attached is the old authentication-ldap.cfg that works.

I'll try to take a look at it later.

> Also the LDAPAuthenticate.java with the group feature added.

I created a branch in my repo for it for ease of reviewing and commenting:
https://github.com/helix84/DSpace/commit/b0d04133d599d2fc88c7e3c6798c727a200eceb0

We'll surely need to work on this. For one, this modifies the
(non-hierarchical) LDAPAuthentication from DSpace 1.8. In 3.x, we
merged LDAPAuthentication and LDAPHierarchicalAuthentication into
LDAPAuthentication. Secondly, I don't like how the group name is
passed in the ldapTGroup variable. I understand why you did it that
way, but there must be a better way, we'll have to figure that out.

We'll also need a Jira issue for this new feature. Or did you manage
to find the old issue number?


Regards,
~~helix84

Compulsory reading: DSpace Mailing List Etiquette
https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette

------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette

Reply via email to