Thanks Christian to have reported that. The comment is wrong it was introduced
when discovery was used only for search.
SolrBrowse needs to have withdrawn items in the index because a browse
withdrawn (and also private) items function exist.
I'm out of office so it will be appreciate if you can fire a jira issue or a PR
to record the need to fix the comment.
Best,
Andrea
Inviato da Samsung Mobile
<div>-------- Messaggio originale --------</div><div>Da: Christian Scheible
<[email protected]> </div><div>Data:25/04/2014 09:48
(GMT+01:00) </div><div>A: dspace-tech <[email protected]>
</div><div>Oggetto: [Dspace-tech] Potential Bug in SolrBrowseCreateDAO
</div><div>
</div>Hi together,
I found a potential Bug in
org.dspace.browse.SolrBrowseCreateDAO.additionalIndex(Context,
DSpaceObject, SolrInputDocument).
At least the comment suggests (and it makes sense) that withdrawn items
schould not be indexed. But the if clause says:
if it is archived OR withdrawn => start indexing.
The code is in line 131 and looks like:
// now index the new details - but only if it's archived and not withdrawn
if (item.isArchived() || item.isWithdrawn())
Regards
Christian
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
DSpace-tech mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-tech
List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette
