Bug Tracker item #2906566, was opened at 2009-12-01 08:51 Message generated for change (Comment added) made by sbajic You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=2906566&group_id=250683
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None >Group: v3.9.0 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Alin Nastac (mrness) Assigned to: Stevan Bajic (sbajic) Summary: solution for bug 2774657 is incorrect Initial Comment: Calling AC_LINK_IFELSE twice makes no sense (why would the second compile test fail?). Instead, sqlite_drv.m4 and sqlite3_drv.m4 should do the following: - if cross-compiling then break 2 (ds_sqlite_lib_success is already set to yes) - else do AC_RUN_IFELSE ---------------------------------------------------------------------- >Comment By: Stevan Bajic (sbajic) Date: 2009-12-01 23:12 Message: Hello Alin, it's fixed in GIT. Thanks for reporting the issue. -- Kind Regards from Switzerland, Stevan Bajić ---------------------------------------------------------------------- Comment By: Stevan Bajic (sbajic) Date: 2009-12-01 15:12 Message: Hallo Alin, Ohhh boy am I blind? LINK? You are right! It should be RUN! When I am back in the office I am going to change that AC_LINK_IFELSE to AC_RUN_IFELSE. Thanks for spotting that little but important difference. -- Kind Regards from Switzerland, Stevan Bajić ---------------------------------------------------------------------- Comment By: Alin Nastac (mrness) Date: 2009-12-01 14:59 Message: Hi Stevan, Yes, I'm speaking about the AC_LINK_IFELSE located at line 213. AC_LINK_IFELSE macro will only try to compile the program while AC_RUN_IFELSE also runs it (it will fail if program ends with a non-zero code). The test source code is designed to be executed, therefore it has to be passed to the AC_RUN_IFELSE, excepting of course cross-compiling case when this test should be skipped. ---------------------------------------------------------------------- Comment By: Stevan Bajic (sbajic) Date: 2009-12-01 12:49 Message: Hallo Alin, you mean the second AC_LINK_IFELSE at line 213? http://dspam.git.sourceforge.net/git/gitweb.cgi?p=dspam/dspam;a=blob;f=m4/sqlite3_drv.m4;h=1a768d0e5dcf5c5023ad7fc1a32733605cb6b458;hb=80694276940d0e068d9e71c53429f172fce7c0e5#l213 The first one on line 197 is just checking if SQLite is available. The second on line 213 is checking if the installed SQLite libraries are the same as the installed header files. If I understand you right, then you would break 2 on the second AC_LINK_IFELSE in case some one is cross-compiling. Right? -- Kind Regards from Switzerland, Stevan Bajić ---------------------------------------------------------------------- Comment By: Stevan Bajic (sbajic) Date: 2009-12-01 12:38 Message: Alin Năstac! :) When you are digging out old issues then there must be something in Gentoo land not compiling the way it should. Right? Do we have any thing in b.g.o because of that wicked sqlite_drv.m4/sqlite3_drv.m4? I am currently away from my office and can't look at that issue. Do you have any patch you could submit for that issue? -- Kind Regards from Switzerland, Stevan Bajić ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=2906566&group_id=250683 ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ Dspam-devel mailing list Dspam-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspam-devel
