On Sat, 17 Apr 2010 15:07:46 +0200
Julien Valroff <jul...@kirya.net> wrote:

> Hi Stevan,
> 
Hallo Julien,


> While working on including dspam_maintenance in the Debian package, I
> have found some (very tiny) issues:
> 
> The built-in echo command in dash (Debian Almquist Shell, now the
> default interpreter for /bin/sh in Debian) doesn't interpret -e option.
> It is hence necessary to call /bin/echo in these cases
> 
> In the usage line, there is an extra \ before the verbose option
> \[--verbose]\n
> should be
> [--verbose]\n
> 
> Also, even without --verbose, there are some outputs:
> @@ -73,10 +73,10 @@
>         fi
>         if [ "${PURGE_SIG}" = "YES" ]
>         then
> -               echo " (with purging old signatures)"
> +               [ "${VERBOSE}" = "true" ] && echo " (with purging old 
> signatures)"
>                 ${DSPAM_BIN_DIR}/dspam_clean ${ADD_PARAMETER} 
> -s${SIGNATURE_AGE} -p${NEUTRAL_AGE} 
> -u${UNUSED_AGE},${HAPAXES_AGE},${HITS1S_AGE},${HITS1I_AGE} >/dev/null$
>         else
> -               echo " (without purging old signatures)"
> +               [ "${VERBOSE}" = "true" ] && echo " (without purging old 
> signatures)"
>                 ${DSPAM_BIN_DIR}/dspam_clean ${ADD_PARAMETER} 
> -p${NEUTRAL_AGE} -u${UNUSED_AGE},${HAPAXES_AGE},${HITS1S_AGE},${HITS1I_AGE} 
> >/dev/null 2>&1
>         fi
>         return ${?}
> 
> 
> I have had to replace mysql_config calls by mysql calls (which work) as
> the mysql_config binary is in the libmysqlclient-dev binary package in
> Debian (which depends on other development packages, hence I won't add
> this dependency for dspam).
> 
> I wonder why the sqlite3 purge script isn't searched for, as for the
> mysql and pgsql scripts?
> 
All of the above fixed now in GIT. Thanks for reporting the issue. Can you test 
and let me know if it works now better under Debian?


> Cheers,
> Julien
> 
-- 
Kind Regards from Switzerland,

Stevan Bajić

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspam-devel mailing list
Dspam-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspam-devel

Reply via email to