On Tue, 03 Aug 2010 09:36:46 +0200 Tom Hendrikx <t...@whyscream.net> wrote:
> Hi, > Hello Tom, > My gentoo overlay containing dspam ebuilds is listed on the DSPAM > wiki. The overlay contains working ebuilds for 3.9.0, 3.9.1-rc1 and git > installs. Since some weeks, the URL has changed. The current ebuilds are > available at: > https://svn.whyscream.net/whyscream-overlay/experimental/mail-filter/dspam/ > can I give some feedback regarding the Ebuild? IMHO using tr is good but introduces another dependency to an binary that not everyone has installed. I would use bash string substitution to do the same without using tr. Replace this: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= # fix for RC naming scheme MY_PV=$(replace_version_separator 3 '-' | tr '[:lower:]' '[:upper:]') MY_P=${PN}-${MY_PV} =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= with this: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= # fix for RC naming scheme MY_PV=$(replace_version_separator 3 '-') MY_P=${PN}-${MY_PV/-rc/-RC} =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= IMHO the quotes around ${DSPAM_HOMEDIR}, ${DSPAM_CONFDIR} and ${DSPAM_LOGDIR} are not needed. You should/could remove them. Replace those lines: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= --with-dspam-home="${DSPAM_HOMEDIR}" \ --sysconfdir="${DSPAM_CONFDIR}" \ --with-logdir="${DSPAM_LOGDIR}" \ =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= with: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= --with-dspam-home=${DSPAM_HOMEDIR} \ --sysconfdir=${DSPAM_CONFDIR} \ --with-logdir=${DSPAM_LOGDIR} \ =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= You can minimize the dependency on external binaries by not using 'seq'. Replace this: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= for euid in $(seq 1000 5000 ) ; do =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= with this: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= for euid in {1000..5000}; do =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= And this: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= for egid in $(seq 1000 5000 ) ; do =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= with this: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= for egid in {1000..5000}; do =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Inside rc_configure() I would add this small code at the end of the function to fix the double --sysconfdir output: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= # Quick and dirty fix for double --sysconfdir in output of dspam --version sed -i -e "s:^\(.*\)['\"]\-\-sysconfdir=.*['\"][\t ]\(.*['\"]\-\-sysconfdir=.*['\"].*\):\1\2:g" \ src/auto-config.h =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > I've tried to login into the wiki to update it, but it seems that > editing the page > (http://sourceforge.net/apps/mediawiki/dspam/index.php?title=Operating_System_Compatibility) > is only accessible for project members. Could you please update the > ebuild location? > If you want write access to the Wiki then contact Paul Cockings <paulcocki...@users.sourceforge.net>. > -- > Regards, > Tom > -- Kind Regards from Switzerland, Stevan Bajić ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm _______________________________________________ Dspam-devel mailing list Dspam-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspam-devel
