Bug Tracker item #3123162, was opened at 2010-11-30 07:09
Message generated for change (Comment added) made by fhanzlik
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3123162&group_id=250683

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: v3.9.1
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Julien Valroff (valroff)
Assigned to: Stevan Bajic (sbajic)
Summary: Patch to remove most of the unused direct dependencies

Initial Comment:
Hi,

You will find attached a patch worked out by Thomas Preud'homme and I which 
removes unused direct dependencies on most of the executables and libraries 
built by DSPAM.

The only left is a dependency on libpthread for dspam_crc:
% ldd -u -r /usr/bin/dspam_crc 
Unused direct dependencies:
        
        /lib/i686/cmov/libpthread.so.0

I don't know how it can be easily removed as all others really depend on 
symbols of libpthread.

Also, one should have a look if this doesn't break anything when building as a 
static driver, though it shouldn't, it wasn't tested.

It would be great to get this patch committed.

Cheers,
Julien

----------------------------------------------------------------------

Comment By: franta (fhanzlik)
Date: 2010-12-04 22:36

Message:
Sorry, I'm not programmer and maybe not right, but it seems as this patch
broken anything - linking with math library isn't invoked when building 
statically linked (hash only?) driver. Then
"src/tools.hash_drv/Makefile.am" conditions
if DYNAMIC_DRIVER
if BUILD_HASH_DRV
cssstat_CPPFLAGS = $(libhash_drv_cppflags)
cssstat_LDFLAGS += $(libhash_drv_libs) $(libhash_drv_ldflags)
cssstat_LDADD = -lm
endif
endif

aren't satisfied and linking ends with error:

/bin/sh ../../libtool --tag=CC   --mode=link gcc  -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -Wall -Wmissing-prototypes
-Wmissing-declarations -I../../src  -rdynamic      -o cssstat
cssstat-cssstat.o cssstat-read_config.o cssstat-util.o cssstat-diction.o
cssstat-nodetree.o cssstat-hash_drv.o cssstat-error.o
cssstat-config_shared.o cssstat-pref.o  -pthread     
libtool: link: gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -Wall -Wmissing-prototypes
-Wmissing-declarations -I../../src -rdynamic -o cssstat cssstat-cssstat.o
cssstat-read_config.o cssstat-util.o cssstat-diction.o cssstat-nodetree.o
cssstat-hash_drv.o cssstat-error.o cssstat-config_shared.o cssstat-pref.o
-pthread  -pthread
cssstat-util.o: In function `chi2Q':
/home/hanzlik/src/rpm/BUILD/dspam-3.9.0-git.20101204.050400/src/tools.hash_drv/../util.c:712:
undefined reference to `exp'
collect2: ld returned 1 exit status
make[3]: *** [cssstat] Error 1



----------------------------------------------------------------------

Comment By: Stevan Bajic (sbajic)
Date: 2010-11-30 09:23

Message:
Hallo Julien, thanks for the patch. It's applied to GIT now.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3123162&group_id=250683

------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus 
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
Dspam-devel mailing list
Dspam-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspam-devel

Reply via email to