Bug Tracker item #3141675, was opened at 2010-12-22 13:03 Message generated for change (Tracker Item Submitted) made by unwesen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3141675&group_id=250683
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jens Finkhaeuser (unwesen) Assigned to: Nobody/Anonymous (nobody) Summary: Unlearning a message is broken Initial Comment: I've been trying to figure out why it seems impossible to teach dspam to unlearn whitelisting. While doing so, I've stumbled across a bug that appears to be unrelated. In libdspam.c, ca. line 1280: if (CTX->classification == DSR_ISINNOCENT) { if (CTX->flags & DSF_UNLEARN) { if (CTX->classification == DSR_ISSPAM) { if (occurrence) { ds_term->s.innocent_hits -= ds_term->frequency; if (ds_term->s.innocent_hits < 0) ds_term->s.innocent_hits = 0; } else { ds_term->s.innocent_hits -= (ds_term->s.innocent_hits>0) ? 1:0; } } So if the email is classified as innocent, and the unlearn flag is set, then check whether the email is spam before doing anything. How can that be right? At this point, the email is already known to be innocent, so the check for whether it's spam must always fail. A similar issue can be found a few lines further down, ca. 1325. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126467&aid=3141675&group_id=250683 ------------------------------------------------------------------------------ Forrester recently released a report on the Return on Investment (ROI) of Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even within 7 months. Over 3 million businesses have gone Google with Google Apps: an online email calendar, and document program that's accessible from your browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew _______________________________________________ Dspam-devel mailing list Dspam-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspam-devel