-------- Original Message -------- Subject: Re: DSPAM: information about a specific commit Date: Tue, 27 Nov 2012 10:28:10 +0100 From: Tom Hendrikx <t...@whyscream.net> To: d...@duckcorp.org
On 11/26/12 3:33 PM, Marc Dequènes (duck) wrote: > Coin, > > Not so long ago, i saw commit 87c1689539567b8af0e4e11df251d974cdd8c9e5 > reverting 2169b243927712edbb22b51d7f61b97d79de9103 without explanation. > I waited some time in hope another solution would be found and > committed, but nothing came. > > I've got friends living in Japan, and in their situation the web > interface is plain unusable, because they receive mails in multiple > encodings and the display is broken for non-latin ones. Thus, until a > solution is found or this patch reapplied, i'm stuck with an ancient > DSPAM version. > > So, could you explain me what was the problem with this patch ? I might > be able to help. > cc-ing dspam-devel. Commit is: http://dspam.git.sourceforge.net/git/gitweb.cgi?p=dspam/dspam;a=commit;h=87c1689539567b8af0e4e11df251d974cdd8c9e5 Hi Marc, The problem is simple: the patch is fine, but it does not compile on systems that don't have iconv installed, or have iconv installed but in a non-standard location. Leaving the patch in-tree would leave the tree in an uncompilable state on a number of systems that we currently support, f.i. FreeBSD. To fix the problem, we would need some extra stuff in ./configure that allows flexibility with iconv usage: enable/disable and pass in non-standard install locations, and some minor code changes to the existing patch to make use of the at configure-time defined variables. I spent some time getting the iconv.m4 from http://www.gnu.org/software/libiconv/ integrated but insofar I failed miserably. Feel free to try it yourself. I'd be very happy to review and commit this, as I really think the current behaviour is ugly. The goals are as simple as: - use iconv on systems where it is available (even on non-standard locations). - allow to use non-iconv handling (aka 'the olde way') when iconv is not available - bonus points: leave room for future enhancements that allow the utf-8 handling with some other library. Kind regards, Tom ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ Dspam-devel mailing list Dspam-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspam-devel
