E.H.Eefting wrote:
-The way mails are deleted from quarantine in the WebUI leaves a lot
to desire: The whole quarantine (which can be hunders of megabytes)
would be loaded in to memory.
You need to either set your MaxMessageSize a *lot* lower or you need to
clear your quarantine more often... ;-)
Even better would be to use Maildir instead of Mailbox format to
store message in the quarantine. Any ideas about if this is possible
and if its a good idea?
I've been thinking about this for some time now, but I decided it would
involve a more complete rewrite of the Web GUI than I have the time for
at the moment. I'd be happy to help test anything you produce, however. :)
Some things [in random order] to consider:
1) abstract out the code that moves messages from new/ to cur/, so that
a user-defined number of quarantined message could be displayed at any
given time (good design practices is to never have more lines displayed
than will fit on X-screens in a normal browser, where X is a strongly
held belief [mine is 2] rather than some objective value). This messes
up the "sort by score" but I don't honestly find that all that helpful
myself. There are modules on CPAN to deal with Maildir's (Don't Create
New Code when someone [presumably smarter] has already created a module
to do it for free).
2) You don't need to touch the core dspam C code (since there is already
an option for a quarantine agent); investigate safecat (Google is your
friend) instead of creating some new code to handle Maildir processing.
3) Ideally, start from scratch using a template tool like HTML::Mason
and stop mixing presentation with code in such an incestuous fashion.
The main code should involve nothing more than creating an appropriately
shaped object and then entering an event loop, instead of the monolithic
code that currently exists. This would also make it much cleaner to
share common code between the admin and normal user (by moving it to
either templates or modules). It would also improve performance, but
that should not be the first priority (optimize second or not at all,
rather than fret about it up front).
My 2 cents
John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5748
