Mark Rogers wrote:
I've just built from CVS and checked the changelog, and as far as I
can tell there's been no change that would resolve this problem. Can
anyone confirm that if dspam --deliver (with --source=error) fails
because of a missing signature then an error is logged but the return
code is 0?
Last email on this for tonight....
I think I have confirmed that "dropping message" does not generate a
non-zero result code, and I think a possible fix would be as shown below.
That said I don't know anything about the dspam architecture, there may
be a reason why there's no error code returned here and/or EFAILURE may
be the wrong error code to use. Unfortunately my live system is built
around Debian packages (3.6.8) so testing this is *very* non-trivial for me.
Anyway, over to someone with some knowledge to comment...
--- src/dspam.c 2008-05-06 19:26:07.000000000 +0100
+++ src/dspam-mcr.c 2008-07-22 19:44:58.000000000 +0100
@@ -1888,6 +1888,7 @@
ATX->classification != DSR_NONE)
{
deliver = 0;
+ retcode = EFAILURE;
LOG (LOG_WARNING,
"process_message returned error %d. dropping message.",
result);
}
--
Mark Rogers // More Solutions Ltd (Peterborough Office) // 0845 45 89 555
Registered in England (0456 0902) at 13 Clarke Rd, Milton Keynes, MK1 1LG
!DSPAM:1011,48862bb2150921297717669!
