On Apr 3, 2008, at 6:50 AM, Chad Mynhier wrote:
> On Wed, Apr 2, 2008 at 8:00 PM, Adam Leventhal <[EMAIL PROTECTED]>
> wrote:
>> On Tue, Apr 01, 2008 at 11:57:54PM -0700, Brendan Gregg - Sun
>> Microsystems wrote:
>>>> I've put up a webrev for this at the following URL:
>>>>
>>>> http://cr.opensolaris.org/~cmynhier/brendan/
>>>
>>> This is great work! :)
>>>
>>> This webrev can seriously be used as a reference for understanding
>>> DTrace
>>> action internals - including the test suite addition.
>>
>> Agreed. In all seriousness, you should blog this or even consider
>> adding it
>> to the DTrace wiki as an example of how to add an action. With some
>> documentation it would make a great tutorial.
>
> It did occur to me while I was implementing it that I was learning a
> few new things about DTrace internals (not to mention realizing after
> I'd finished that this really just should have been a macro hard-coded
> into the language rather than an action, as there's no data coming out
> of the kernel.)
I did notice that in .../uts/common/dtrace/dtrace.c you did:
9580 + case DTRACEACT_BRENDAN:
9581 + size = sizeof (uint64_t);
9582 + break;
9583 +
I think you should be leaving size alone; you aren't returning any
data.
Cheers,
- jonathan
_______________________________________________
dtrace-discuss mailing list
[email protected]
