Hi Jon, Looks good!
I guess the thing which most people are going to pick up on is the sampling granularity. I just wonder whether you should always have to specify this, or whether you should pick up some sensible (safe) default; I guess there are pros and cons, the downside being that the default might change underneath you. Also your third example; maybe I'm nitpicking but does this really do what it says: 3. L2 cache misses, by function, generated by any running executables called 'brendan' on an AMD platform. cpc:::BU_fill_req_missed_L2-all-0x7-10000 /execname == "brendan"/ { @[ufunc(arg1)] = count(); } The filter's applied in the D, after the probe has fired, so surely the probe firing indicates there have been 10000 global L2 cache misses, and it just so happens this time the probe has fired whilst "brendan" is on CPU? It doesn't necessarily mean there have been 10000 firings whilst "brendan" was on CPU. I could have misunderstood, it could be nitpicking, and I know it's a subtlety, but AIUI this is different to how cputrack (say) would work. Regards, -- Philip Beevers Chief Architect - Fidessa mailto:[EMAIL PROTECTED] phone: +44 1483 206571 > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Jon Haslam > Sent: Monday, July 14, 2008 11:42 AM > To: Solaris Dtrace List > Subject: [dtrace-discuss] CPC provider - input welcome > > Tracing Fans, > > I know it's been a long time in coming but the CPU > Performance Counter (CPC) provider is almost here! The code > is currently in for review and a proposed architecture > document is attached here for review. > > Any and all feedback/questions on the proposed implementation > is welcome. > > Thanks. > > Jon. > ******************************************************************************************************************************************************************************************** This message is intended only for the stated addressee(s) and may be confidential. Access to this email by anyone else is unauthorised. Any opinions expressed in this email do not necessarily reflect the opinions of Fidessa. Any unauthorised disclosure, use or dissemination, either whole or in part is prohibited. If you are not the intended recipient of this message, please notify the sender immediately. Fidessa plc - Registered office: Dukes Court, Duke Street, Woking, Surrey, GU21 5BH, United Kingdom Registered in England no. 3781700 VAT registration no. 688 9008 78 Fidessa group plc - Registered Office: Dukes Court, Duke Street, Woking, Surrey, GU21 5BH, United Kingdom Registered in England no. 3234176 VAT registration no. 688 9008 78 _______________________________________________ dtrace-discuss mailing list dtrace-discuss@opensolaris.org