Hi Brendan,
Brendan Gregg - Sun Microsystems wrote:
> On Tue, Dec 09, 2008 at 05:04:49PM +0100, [EMAIL PROTECTED] wrote:
>
>> Hi,
>> I have looked at the script, and there is no correspondence between
>> start and done.
>> So, I am not sure how this script is supposed to work.
>> I think there should be a predicate in the done probes...
>> The way the script is written, it assumes that for any start, the done
>> that fires after it is for the same noi_xid.
>>
>> Current script:
>>
>> nfsv3:::op-read-start,
>> nfsv3:::op-write-start
>> {
>> start[args[1]->noi_xid] = timestamp;
>> }
>>
>> nfsv3:::op-read-done,
>> nfsv3:::op-write-done
>> {
>> ...
>>
>> Changed script:
>>
>> nfsv3:::op-read-start,
>> nfsv3:::op-write-start
>> {
>> start[args[1]->noi_xid] = timestamp;
>> }
>>
>> nfsv3:::op-read-done,
>> nfsv3:::op-write-done
>> /start[args[1]->noi_xid] != 0/
>> {
>>
>> That way, you don't have the done probe clause executing
>> for id's where the start has not fired first.
>>
>
> Thanks, unusual for me to miss that. Anyway, now fixed on the wiki.
>
>
>> (This still does not
>> match start/done for a given xid).
>> But what do I know...
>>
>
> The xid is the key in the hash...
>
>
Yes, and I think the check for non-zero is sufficient...
> Brendan
>
>
_______________________________________________
dtrace-discuss mailing list
dtrace-discuss@opensolaris.org
