On Tue, 2010-08-17 at 14:40 -0700, David Borowitz wrote: > I'm not a huge fan of inlining this function as opposed to a > conditionally-defined macro or header file. What if we want to use > strlen in other places? Me neither. The issue there though is that we'd have to add a complex test in setup.py to see if the system provides a strnlen() implementation.
If we end up with strnlen() in more places I think we should revisit this decision, and perhaps go the more complex route instead. Cheers, Jelmer > On Tue, Aug 17, 2010 at 14:36, Jelmer Vernooij <[email protected]> > wrote: > > On Tue, 2010-08-17 at 23:30 +0200, Hans Kolek wrote: > > I've patched dulwich to compile with mingw. The patch is > attached. As > > you can see I've just removed the strnlen call and replaced > it with > > its implementation. > > This looks alright, but please don't use declarations after > statements, > as they break some compilers. > > Cheers, > > Jelmer > > > _______________________________________________ > Mailing list: https://launchpad.net/~dulwich-users > Post to : [email protected] > Unsubscribe : https://launchpad.net/~dulwich-users > More help : https://help.launchpad.net/ListHelp > >
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Mailing list: https://launchpad.net/~dulwich-users Post to : [email protected] Unsubscribe : https://launchpad.net/~dulwich-users More help : https://help.launchpad.net/ListHelp
