On Sun, 2010-11-14 at 19:19 -0600, Augie Fackler wrote: > First patch is trailing whitespace cleanup courtesy of my .emacs, I > don't feel strongly about it. I'll merge this one.
> Second patch removes an assertion which only gets hit on > non-c-extension builds. I noticed it when I was using a broken install > and ended up using the Python parsing code instead of the native code, > which worked fine on the repo in question. It's been lurking around so > long I've forgotten which repository this broke on, but I can dig it > up again if you want. This assertion is actually correct. It's come up a couple of times recently because GitHub sometimes writes invalid data. Apparently this makes jgit fall over too and cgit's fsck warns about it. I am hesitant to remove this assertion without adding some code to .check() to point it out and a test to demonstrate we now handle it correctly. > If you'd rather have a pull request on github, that's fine, happy to > resend there. Also, please let me know if this patchbomb gives you any > problems, as I sent it with Mercurial. This seems to work correctly at the moment. I also wouldn't mind if you sent Mercurial bundles though, I still have to implement those in bzr-hg and I could use some test cases. ;-) Cheers, Jelmer
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Mailing list: https://launchpad.net/~dulwich-users Post to : [email protected] Unsubscribe : https://launchpad.net/~dulwich-users More help : https://help.launchpad.net/ListHelp
