On Mon, Dec 27, 2010 at 06:03:12PM -0800, Dave Borowitz wrote: > On Sun, Dec 26, 2010 at 18:04, Jelmer Vernooij <[email protected]> wrote: > > > On Mon, Dec 27, 2010 at 02:46:51AM +0100, Jelmer Vernooij wrote: > > > On Sun, Dec 26, 2010 at 04:23:54PM -0500, Augie Fackler wrote: > > > > >> We can codify that in setup.py and make > > > > >> it the One True Test System (and depending on unittest2 for old > > > > >> Pythons means that we can continue using the normal SkipTest > > > > >> approach *and* dispense with the madness in test/__init__ that tries > > > > >> to get the "right" SkipTest. I'm happy to take on this work if > > > > >> nobody objects. > > > > > I can live with unittest2 as default fallback test runner but > > > > > would like to keep the support for using testtools without the need > > to > > > > > install unittest2. What do you think about the attached patch? > > > > Should probably also list unittest2 in the test_requires stanza of the > > > > setup() call in setup.py if sys.version < (2,7). > > > That's a good point. > > I've pushed the switch to unittest + unittest2 but without the > > test_requires stanza. > > Not having it doesn't seem to break anything (we never had it for nose) and > > I can't > > work out what to set exactly. Patches to add it welcome. > > > I haven't been following this discussion closely, but what you just pushed > fails on 2.6 even after installing (with pip) unittest2 and testtools (trace > below). > > I don't really care what the ultimate answer is, but I'd appreciate it if > you could run any more potential fixes by me so I can try the tests against > master with my setup. Can you perhaps try:
make check TESTRUNNER=unittest2.__main__ ? Cheers, Jelmer _______________________________________________ Mailing list: https://launchpad.net/~dulwich-users Post to : [email protected] Unsubscribe : https://launchpad.net/~dulwich-users More help : https://help.launchpad.net/ListHelp
