THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#158 - Decide whether gradients should have dimension dim or dimworld User who did this - Bernd Flemisch (bernd) ---------- We should at least try to resolve the naming issue associated with this. Probably all of our (dimWorld) gradients are DimVectors. According to our naming convention, a DimVector is typedef Dune::FieldVector<Scalar, dim> DimVector; We already have mixed that up, e.g. in implicitdarcyfluxvariables.hh, we have typedef Dune::FieldVector<Scalar, dimWorld> DimVector; We have 728 occurrences of DimVector in our stable part, so there is quite a bit to be checked. We have several options: 1. The gradients stay DimVectors. a) We consistently have only typedefs like typedef Dune::FieldVector<Scalar, dim> DimVector; for our gradients. This fits with our naming convention and the name is not misleading. However, it will produce compiler errors if we ever try to have dim < dimWorld. b) We consistently have only typedefs like typedef Dune::FieldVector<Scalar, dimWorld> DimVector; for our gradients. This will work if we have dim < dimWorld. However, the naming is misleading, and although our dim < dimWorld stuff might compile easier, we for sure will have other issues with it. 2. The type for gradients is renamed. a) To GlobalPosition. This is consistent with our naming convention, nevertheless the name might be misleading. There is a lot more to change than for 1. b) To something else, maybe GlobalGradient? We have the chance to come up with an intuitive name. However, it might clash with the name GlobalPosition, which stands for the same data type. There is also a lot more to change than for 1. Let us decide this in the Dumux coffee on Monday. Please vote here before if you cannot attend. ---------- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=details&task_id=158#comment318 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. _______________________________________________ Dumux mailing list [email protected] https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
