THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below.
User who did this - Bernd Flemisch (bernd) Attached to Project - DuMuX Summary - Get rid of floating point comparisons Task Type - Bug Report Category - General Status - New Assigned To - Operating System - Unspecified Severity - Low Priority - Normal Reported Version - SVN Due in Version - 2.7 Due Date - Undecided Details - I learned today that there is the flag "-Wfloat-equal" that triggers warnings in case of "==" and "!=" comparisons of floating point numbers. The tested part of dumux-stable contains 181 such comparisons, see the list below. Unless they are justified, we should get rid of them. dumux/common/math.hh:112:11 dumux/common/math.hh:142:11 dumux/common/math.hh:176:20 dumux/common/math.hh:212:11 dumux/common/math.hh:227:11 dumux/common/math.hh:227:23 dumux/common/math.hh:232:16 dumux/common/math.hh:232:28 dumux/common/math.hh:243:16 dumux/common/math.hh:243:28 dumux/common/math.hh:82:36 dumux/common/splinecommon_.hh:248:24 dumux/common/splinecommon_.hh:249:24 dumux/common/splinecommon_.hh:250:19 dumux/common/splinecommon_.hh:559:18 dumux/common/splinecommon_.hh:561:21 dumux/common/timemanager.hh:413:24 dumux/decoupled/2p2c/celldata2p2cadaptive.hh:157:38 dumux/decoupled/2p2c/fv2dtransport2p2cadaptive.hh:540:78 dumux/decoupled/2p2c/fv2dtransport2p2cadaptive.hh:543:83 dumux/decoupled/2p2c/fv2dtransport2p2cadaptive.hh:553:77 dumux/decoupled/2p2c/fv3dtransport2p2cadaptive.hh:546:78 dumux/decoupled/2p2c/fv3dtransport2p2cadaptive.hh:548:83 dumux/decoupled/2p2c/fv3dtransport2p2cadaptive.hh:558:77 dumux/decoupled/2p2c/fvpressure2p2c.hh:1026:67 dumux/decoupled/2p2c/fvpressure2p2c.hh:1029:48 dumux/decoupled/2p2c/fvpressure2p2c.hh:271:29 dumux/decoupled/2p2c/fvpressure2p2c.hh:786:40 dumux/decoupled/2p2c/fvpressure2p2c.hh:790:39 dumux/decoupled/2p2c/fvpressure2p2c.hh:803:42 dumux/decoupled/2p2c/fvpressure2p2c.hh:807:41 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:727:50 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:728:49 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:787:40 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:811:48 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:811:82 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:830:51 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:832:57 dumux/decoupled/2p2c/fvpressure2p2cmultiphysics.hh:977:48 dumux/decoupled/2p2c/fvpressurecompositional.hh:140:42 dumux/decoupled/2p2c/fvtransport2p2c.hh:726:79 dumux/decoupled/2p2c/fvtransport2p2c.hh:729:84 dumux/decoupled/2p2c/fvtransport2p2c.hh:742:73 dumux/decoupled/2p/diffusion/fv/fvpressure2padaptive.hh:456:35 dumux/decoupled/2p/diffusion/fv/fvpressure2padaptive.hh:458:37 dumux/decoupled/2p/diffusion/fv/fvpressure2padaptive.hh:464:40 dumux/decoupled/2p/diffusion/fv/fvpressure2padaptive.hh:465:42 dumux/decoupled/2p/diffusion/fv/fvpressure2padaptive.hh:468:40 dumux/decoupled/2p/diffusion/fv/fvpressure2padaptive.hh:469:42 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:1000:51 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:1002:52 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:751:51 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:752:52 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:764:31 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:766:33 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:773:47 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:774:48 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:960:55 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:961:56 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:993:35 dumux/decoupled/2p/diffusion/fv/fvpressure2p.hh:995:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:318:44 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:319:46 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:320:44 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:321:46 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:329:43 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:330:45 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:331:43 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:332:45 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:378:39 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:380:41 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:386:44 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:387:46 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:390:44 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:391:46 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:506:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:509:38 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:529:35 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:531:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:539:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2padaptive.hh:542:38 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:387:33 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:390:34 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:409:31 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:411:33 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:419:33 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:422:34 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:619:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:622:38 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:646:35 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:648:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:654:37 dumux/decoupled/2p/diffusion/fv/fvvelocity2p.hh:657:38 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2029:27 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2029:41 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2029:55 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2029:69 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2307:27 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2307:41 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2307:55 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2562:36 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2padaptive.hh:2562:52 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2p.hh:1603:23 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2p.hh:1603:37 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2p.hh:1603:51 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2p.hh:1603:65 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2p.hh:1866:36 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressure2p.hh:1866:52 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressurevelocity2padaptive.hh:638:35 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressurevelocity2padaptive.hh:640:37 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressurevelocity2p.hh:501:35 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal2dpressurevelocity2p.hh:503:37 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:15 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:29 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:43 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:57 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:71 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:85 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2512:99 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2padaptive.hh:2513:18 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:15 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:29 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:43 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:57 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:71 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:85 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2131:99 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2132:18 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2413:28 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressure2p.hh:2413:44 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressurevelocity2padaptive.hh:601:35 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressurevelocity2padaptive.hh:603:37 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressurevelocity2p.hh:499:35 dumux/decoupled/2p/diffusion/fvmpfa/lmethod/fvmpfal3dpressurevelocity2p.hh:501:37 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressure2p.hh:1604:23 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressure2p.hh:1604:37 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressure2p.hh:1604:51 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressure2p.hh:1604:65 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressure2p.hh:1947:36 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressure2p.hh:1947:52 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressurevelocity2p.hh:502:35 dumux/decoupled/2p/diffusion/fvmpfa/omethod/fvmpfao2dpressurevelocity2p.hh:504:37 dumux/decoupled/2p/impes/gridadaptionindicator2plocal.hh:110:46 dumux/decoupled/2p/impes/gridadaptionindicator2plocal.hh:133:50 dumux/decoupled/2p/transport/fv/evalcflfluxcoats.hh:578:26 dumux/decoupled/2p/transport/fv/evalcflfluxcoats.hh:578:54 dumux/decoupled/2p/transport/fv/evalcflfluxcoats.hh:584:27 dumux/decoupled/2p/transport/fv/evalcflfluxcoats.hh:584:55 dumux/decoupled/common/impetproblem.hh:374:14 dumux/decoupled/common/impetproblem.hh:374:50 dumux/freeflow/stokes/stokeslocalresidual.hh:193:35 dumux/freeflow/stokes/stokeslocalresidual.hh:202:35 dumux/freeflow/stokes/stokeslocalresidual.hh:496:40 dumux/freeflow/stokes/stokeslocalresidual.hh:567:71 dumux/freeflow/stokes/stokeslocalresidual.hh:606:33 dumux/geomechanics/el1p2c/el1p2clocalresidual.hh:178:17 dumux/geomechanics/el1p2c/el1p2clocalresidual.hh:202:17 dumux/geomechanics/el1p2c/el1p2clocalresidual.hh:225:17 dumux/geomechanics/el1p2c/el1p2clocalresidual.hh:252:17 dumux/implicit/common/implicitdarcyfluxvariables.hh:213:29 dumux/implicit/mpnc/diffusion/diffusion.hh:133:21 dumux/io/interfacemeshcreator.hh:180:53 dumux/linear/amgparallelhelpers.hh:625:50 dumux/linear/amgparallelhelpers.hh:901:24 dumux/linear/amgparallelhelpers.hh:901:26 dumux/linear/amgparallelhelpers.hh:925:14 dumux/linear/amgparallelhelpers.hh:925:16 dumux/material/components/co2tablereader.hh:122:25 dumux/material/components/co2tablereader.hh:130:22 dumux/material/constraintsolvers/compositionalflash.hh:271:24 dumux/material/constraintsolvers/compositionalflash.hh:271:44 dumux/multidomain/couplinglocalresiduals/stokesnccouplinglocalresidual.hh:287:52 dumux/multidomain/couplinglocalresiduals/stokesnccouplinglocalresidual.hh:296:54 dumux/multidomain/couplinglocalresiduals/stokesnccouplinglocalresidual.hh:336:9 dumux/multidomain/couplinglocalresiduals/stokesncnicouplinglocalresidual.hh:294:47 dumux/multidomain/couplinglocalresiduals/stokesncnicouplinglocalresidual.hh:303:49 dumux/multidomain/couplinglocalresiduals/stokesncnicouplinglocalresidual.hh:349:4 2cnistokes2p2cniproblem.hh:324:40 2cstokes2p2cproblem.hh:312:40 2p2cnisubproblem.hh:530:48 2p2csubproblem.hh:414:48 More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=details&task_id=245 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. _______________________________________________ Dumux mailing list [email protected] https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
