THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#238 - Improve terminology in Newton output / parameters User who did this - Bernd Flemisch (bernd) ---------- While I definitely like the physical interpretation, I would prefer generic names. At least for the general NewtonSolver/Controller, since it has to deal with mass balances as well as with energy and momentum balances. I would propose the following changes in nomenclature: Properties/Parameters (all in the group "Newton"): AbsTolerance -> ResidualReduction: Expresses exactly what it does and is consistent with the name in the LinearSolver EnableAbsoluteCriterion -> EnableResidualCriterion RelTolerance -> MaxRelativeShift: the word "shift" is a very meaningful name EnableRelativeCriterion -> EnableShiftCriterion SatisfyAbsAndRel -> SatisfyResidualAndShiftCriterion Output: "relative error" -> "maximum relative shift" "absolute error" -> "residual reduction" If we like, we can still define model-dedicated NewtonControllers that could use parameter names that are closer to the physics and maybe deal with different tolerances for different quantities like pressure, saturations. temperature and so on. Please provide your opinions. ---------- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=details&task_id=238#comment499 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. _______________________________________________ Dumux mailing list [email protected] https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
