THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#263 - Don't build executables on make test User who did this - Timo Koch (timokoch) ---------- Why was it a bad idea? I don't see any downsides so far. A build-tests target is only useful if your tests are spread across the project in separate places, e.g. unit tests are close to the source. In Dumux we adopt the opposite concept. The tests are located in a separate structure that mimics that of the source. We don't want to build all tests on every run of dunecontrol thats why we exclude them from the toplevel "all" target. However, when you are in the subfolder "test" it would seem even surprising to me if "all" wouldn't build ALL executables, thus all tests. Further, there is not currently and not going to be anything else than tests in the dumux/test folder. The tutorials are not tests and shouldn't be build by the suggested build-tests target either.. So technically there is no difference between make all in the folder "test" and make build-tests in the top directory. IMO build-tests is just something inconvenient to implement that clutters our CMake configuration, when we can simply type make "all" in the test subfolder if we have a single additional EXCLUDE_FROM_ALL statement in the topfolder. If everything works just fine with no additional effort why not keep it? I'm really interested why it was a bad idea? ---------- More information can be found at the following URL: http://www.dumux.org/flyspray/index.php?do=details&task_id=263#comment598 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. _______________________________________________ Dumux mailing list [email protected] https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
