Hi Christoph, Thanks for your work. I just want to add that the bug is not only a problem if the fluidsystem contains more than 4 components (in 2D). It will also cause a wrong calculation of the porous diffusion coefficients in general because the elemVolVars which are accessed are not necessarily the ones of the desired SCV corner. So probably, this bugfix will improve the convergence and results. However, the error is most likely small.
Bye Georg -----Ursprüngliche Nachricht----- Von: Dumux [mailto:[email protected]] Im Auftrag von Christoph Grüninger Gesendet: Freitag, 6. November 2015 13:34 An: [email protected] Betreff: Re: [DuMuX] Bug in mpnc model Hi Georg, I just pushed your fix. The variable shadowing was a good catch, thanks for sharing it with us! I was surprised that the compiler did not warn, but I learned that GCC does not add -Wshadow in -Wall or -Wextra. Bye Christoph -- A mathematician is a scientist who can figure out anything, except such simple things as squaring the circle and trisecting an angle. [Evan Esar (1899-1995), Esar's Comic Dictionary] _______________________________________________ Dumux mailing list [email protected] https://listserv.uni-stuttgart.de/mailman/listinfo/dumux
