Hello,

During my experiments with Spe5, I think I just found something in pengrobinson.hh that looks like a bug or some unfinished intention. The findExtrema_method

    static bool findExtrema_(Scalar &Vmin,
                             Scalar &Vmax,
                             Scalar &pMin,
                             Scalar &pMax,
                             Scalar a,
                             Scalar b,
                             Scalar T)

never fills in the given pMin and pMax references. The findCriticalPoint_ method, in turn, never has its

        Scalar minP(0);
        Scalar maxP(1e100);

updated. So it always returns pcrit = (minP + maxP)/2 = 5e99. I guess that is not what it is supposed to do.

Best regards,

Dmitry


_______________________________________________
DuMux mailing list
[email protected]
https://listserv.uni-stuttgart.de/mailman/listinfo/dumux

Reply via email to