On 11.06.2011 18:21, Lekensteyn wrote:
> Lekensteyn has proposed merging lp:~lekensteyn/duplicity/multipass into 
> lp:duplicity.
> 
> Requested reviews:
>   duplicity-team (duplicity-team)
> Related bugs:
>   Bug #684025 in ProjectStats: "Funktionalität von aus den Games in die 
> Tabellen verlagern"
>   https://bugs.launchpad.net/projectstats/+bug/684025
>   Bug #793096 in Duplicity: "Allow to pass different passwords for --sign-key 
> and --encrypt-key"
>   https://bugs.launchpad.net/duplicity/+bug/793096
> 
> For more details, see:
> https://code.launchpad.net/~lekensteyn/duplicity/multipass/+merge/64307
> 
> Enables the use of a different passphrase for the GPG signing and encryption 
> key. (Closes #793096)
> Allows to specify a different secret keyring for the GPG encryption key.
> Updated manual page with the above two changes.
> Do not keep asking for a passphrase confirmation, but start over on asking 
> the passphrase to prevent an infinite loop. (Closes #680425)
> 

massive such a small change ;) .. one question why did you conditionalize 

136     - globals.gpg_profile.passphrase = get_passphrase(2, action)
137     + if not globals.gpg_profile.sign_key:
138     + globals.gpg_profile.passphrase = get_passphrase(2, action)

what happens if one wants to sign a symmetric encryption? currently this worked 
using the agent or the "same pass" for encryption and signing (not suggesting 
of course) .. with your addition this limitation could be lifted easily. did 
you?

thanks for the contribution, ede/duply.net

-- 
https://code.launchpad.net/~lekensteyn/duplicity/multipass/+merge/64307
Your team duplicity-team is requested to review the proposed merge of 
lp:~lekensteyn/duplicity/multipass into lp:duplicity.

_______________________________________________
Mailing list: https://launchpad.net/~duplicity-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~duplicity-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to