Note that this change does introduce another test run. On my machine, each run takes about 5 minutes, so run-tests has increased from taking 10 minutes to 15 minutes. It does, however, make it very clear if any test failures result from Python 2.6, 2.7 or the particular set-up on the build server.
To me, this is probably the best approach. 15 minutes does not seem ridiculous for a final pre-commit test before proposing a merge. If a developer is doing a lot of testing to isolate and fix a bug, they can use the tox commands set out in the README-REPO to test a narrower range of tests, or to only test against one or two test environments (py26, py27 or lpbuildd). If you disagree, however, and think that we need to limit the testing to two runs, there are two obvious options to me: 1) Change the command in testing/run-tests to be "tox -e py26,py27", so that everything is as it was before and the new lpbuildd profile is only used if "tox" or "tox -e lpbuildd" is run (likely by one of us looking for a build issue). 2) Change the command in testing/run-tests to be "tox -e py26,lpbuildd". The Launchpad build server runs Python 2.7 anyway, so testing against Python 2.6 and the Launchpad build server profile should find any issues with either Python version. The key downside to this approach is that if there are any issues, such as the recent issue with Launchpad's mock.patch not taking a return_value argument, it would be harder to determine whether the issue was caused by the Python version or the obsolete build server package versions. -- https://code.launchpad.net/~aaron-whitehouse/duplicity/launchpad_tox_profile/+merge/266859 Your team duplicity-team is requested to review the proposed merge of lp:~aaron-whitehouse/duplicity/launchpad_tox_profile into lp:duplicity. _______________________________________________ Mailing list: https://launchpad.net/~duplicity-team Post to : [email protected] Unsubscribe : https://launchpad.net/~duplicity-team More help : https://help.launchpad.net/ListHelp
