Martin,

although already merged, i don't think it's perfect already.

afaiu gpg2+ _always_ uses the agent if input is necessary. that's why the 
manpage contained, auntil you removed
"
GnuPG 2 and newer ignore this option and will always use a running
.B gpg-agent
if no passphrase was delivered.
"
this is because the passphrase input routines got moved from gpg into 
gpg-agent. 

additionally if we want gpg to ask for a passphrase and block the process we 
need to deliver '--pinentry-mode=loopback', which seems to be used in the 
current gpg.py
  
http://bazaar.launchpad.net/~duplicity-team/duplicity/0.8-series/view/head:/duplicity/gpg.py#L142

1.
out of interest, why did your earlier patch use '--pinentry-mode=cancel'?

2.
please check if gpg2.1 does start a gpg-agent. according to my tests a 
gpg-agent instance is started and keeps lingering if not killed manually.

..ede/duply.net


On 09.02.2017 14:44, Martin Wilck wrote:
> Martin Wilck has proposed merging lp:~mwilck/duplicity/0.7-series into 
> lp:duplicity/0.7-series.
> 
> Requested reviews:
>   duplicity-team (duplicity-team)
> 
> For more details, see:
> https://code.launchpad.net/~mwilck/duplicity/0.7-series/+merge/316852
> 
> Fixed the documentation of --use-agent in the man page. It was still talking 
> about --pinentry-mode=cancel. Also, clarify that the gnupg version dependency 
> applies if the --use-agent parameter is NOT used.
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~duplicity-team
> Post to     : duplicity-team@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~duplicity-team
> More help   : https://help.launchpad.net/ListHelp
> 

-- 
https://code.launchpad.net/~mwilck/duplicity/0.7-series/+merge/316852
Your team duplicity-team is requested to review the proposed merge of 
lp:~mwilck/duplicity/0.7-series into lp:duplicity/0.7-series.

_______________________________________________
Mailing list: https://launchpad.net/~duplicity-team
Post to     : duplicity-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~duplicity-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to