Hello Ken, On May 17 2019, at 4:13 pm, Kenneth Loafman <[email protected]> wrote: > Already have that fixed in setup.py and tox.ini. Anyplace else? > > >
Looks like you've fixed the one I was talking about. > I usually run .run_tests before merging into trunk. I need to pull the latest > and double check. Sorry, that was not meant as a criticism. Doing it manually always means things get missed. It really would be nice if Launchpad had built in CI like some of the others. > > > > On py2 I cannot get past to import even though it's in tox and local > > > site-packages. This causes all of the functional tests to fail. > > Do we need this on Py2? Isn't it to provide Python 2-equivalent > > functionality in Python 3? Can we put the import within a test for Python > > version (and then obviously in future move over to using Python 3 > > constructs). > > > > Yes, past.old_div() is used in multiple modules to keep away from py3's > broken division. > > > I am still getting this when trying to do ./run-tests on trunk, but I see you managed to get 0.8.00 out the door -- how did you fix it on your machine? > > > On py3 there is at least on test failing, test_globmatch.TestGlobToRegex, > > On a quick look this is a simple fix -- looks as though this is just about > > escape characters in the string being treated differently. > OK, could you fix provide a patch? Have not looked at it. > > > Looks as though you managed to get to this before I did, sorry. Kind regards, Aaron
_______________________________________________ Mailing list: https://launchpad.net/~duplicity-team Post to : [email protected] Unsubscribe : https://launchpad.net/~duplicity-team More help : https://help.launchpad.net/ListHelp
