Hi!
Claus Buchberger wrote:
> to get a little feeling for the code of dvbcut I added a simple help
> menu to the main menu. I don't know how to send a patch, so I zipped all
> 5 changed (and one new) files and attached them to this email.
To create a patch, simply run the command
svn diff > patch-against-rxyz.diff
But, please:
- do so from the top-level directory (the one with configure in it)
- add a ChangeLog entry first
- DO NOT RE-INDENT THE CODE!
I will never again accept changes that start like this:
> --- dvbcut.cpp (revision 156)
> +++ dvbcut.cpp (working copy)
> @@ -1,19 +1,19 @@
> /* dvbcut
> - Copyright (c) 2005 Sven Over <[email protected]>
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> -
> - You should have received a copy of the GNU General Public License
> - along with this program; if not, write to the Free Software
> - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + Copyright (c) 2005 Sven Over <[email protected]>
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 2 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, write to the Free Software
> + Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> USA
> */
[about 5600(!) similar lines following]
I want to see at a single glance what you've changed.
> The aboutbox shows the version and a message that the programm is
> distributed under GPL. The simple help file shows the list of all used
> shortcuts (as far as I found them). This is a very simple html-view
> (QTextBrowser in Qt3 seems not to be able to show more complex html
> code) but it may be improved.
I'll check that later. I need to revert the unnecessary format changes
first, to get a minimal diff for review.
> Since Qt4 is available more than 3 years and has lots of new features.
> My suggestion is to do a port to the current version. If there is
> interest let me know.
I'm more interested in a GTK+ interface.
Actually, I don't seriously consider dvbcut a good base for future
development. It has too many shortcomings, and the code is a hell of a
bloody mess. I'd rather put the effort in dvbcut2 than in a new GUI for
the current version. In particular, we need a new indexer (I'm working
on that right now) much more badly than a new GUI.
--
Michael "Tired" Riepe <[email protected]>
X-Tired: Each morning I get up I die a little
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
DVBCUT-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dvbcut-devel
