Hi!
Ralph Glasstetter wrote:
> Hey,
>
> I heard already rumours about that from Sven...
> Well done! I'm sure the windows people can't await to have something simple
> without the need to de/multiplex. ;-)
I looked at the source (or rather, the diffs ;-), and there's one thing
I'm not happy with at all: The substitution of "off64_t" for "off_t". On
Linux, off_t is switched to 64 bit automatically if you use
-D_FILE_OFFSET_BITS=64 (or is 64 bit by default, e.g. on x86_64
systems). I'd rather not interfere with that mechanism. Isn't there a
better solution?
Also, changes like this one:
void inbuffer::setup()
{
unsigned int _size=size;
- struct stat st;
+ struct _stati64 st;
- if ((::fstat(fd,&st)==0)&&(S_ISREG(st.st_mode))) {
+ if ((::_fstati64(fd,&st)==0)&&(S_ISREG(st.st_mode))) {
filesizechecked=true;
filesize=st.st_size;
if (mmapsize>0)
need to be surrounded with #ifdef ... #endif - after all, we still want
to be able to compile the sources on other systems, don't we?
Finally, there seem to be some leftovers from debugging, in particular
the function "breakit" in src/index.cpp.
> PS: Don't forget to add my little XML chapters I posted a few minutes
> ago... :-)
I'll test your patch this weekend.
--
Michael "Tired" Riepe <[EMAIL PROTECTED]>
X-Tired: Each morning I get up I die a little
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
DVBCUT-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dvbcut-user
