Hi, Am Montag, 29. Oktober 2007 14:36 schrieb Michael Riepe: > >>>- if (it->export_flag) > >>>+ if (it->export_flag && it!=quick_picture_lookup.end()) > >> > >>I'm pretty sure this change is useless. `it' can't be at the end of the > >>list because it has just been decremented (i.e. moved towards the front > >>by one position). > > > > Hmmm,... of course you are right... very strange,... I thought I tested > > that...?!? :-| > > Since the new additional condition is always true, I bet you didn't > notice any difference.
If I would have test it, yes... but most probable I just wanted to test did, did instead somting different and forgot about it... ;-) > > > OK,... in the updated patch file it is now compared to > > "quick_picture_lookup.end()-1"! > > A cleaner solution maybe would be to set the export_flag of a START-entry > > only to true, if there follows a STOP-entry...? > > I'd rather keep the flag and make dvbcut act accordingly (i.e. export > everything from the last start marker up to EOF). OK, but this would require a change in philosophy (in FileExport)... up to now ALL unmatched START/STOP marker are ignored... And if we allow for an implicite [EMAIL PROTECTED] we also should allow a implicite [EMAIL PROTECTED] (as it's the case in Batch-Mode without any Markers)! > > > The appended patch also implements no strict CLI overrules PRJ and adds > > a few more context menu entries (hmmm..., quite a long list now!). > > Too long, in my opinion - a context menu should have at most half a > dozen entries, approximately. Maybe we should move similar entries to > submenus (e.g. the whole "Delete all X" and "Convert to X" stuff). > That's a possibility,... if someone knows how to implement that with QT-Designer... ;-) > By the way: I would prefer separate patches for every bugfix and every > new feature. With these monster patches, it's too hard to track errors > because you always have to review all changes. With "atomic" patches, on > the other hand, you can e.g. remove a single feature and check if the > problem persists. > Of course, you're right... the next time I'll split them! Actually this just was intendended as timestamp patch, before I found those 2-3 bugs... ;-) ciao Ralph ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ DVBCUT-user mailing list DVBCUT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dvbcut-user
