Hi! Ralph Glasstetter wrote:
> just wanted to ask how to proceed with the pipe patch because I have a few > other patches in the queue (multiple input files now also under recentfiles, > arbitrary position of CLI options / files...) :) > > How do you want them? Everthing together in one diff or two different diffs > refering to r107,... or should I wait with the second one and make it > refering to future r108? If they both modify the same files (e.g. dvbcut.cpp), it's probably better to send me the whole bunch as a single diff. Otherwise, I prefer separate diffs. [...] >>The >>improved pipe command stuff also went in, so we're now at r107. > > Great... but what should we do with the checks for executable and/or return > codes? Hmm... add them? ;) > I tried checking waitpid but this returned nothing special when the > executable > is not found! Checking the exit status with wait/waitpid is a little tricky. You need to evaluate the `status' argument to find out what happened. But I can add that myself. > So the 'which'-version is working for me, but maybe neither "universal" nor > "elegant" ... the QFileInfo-Version is better concerning this but not making > use of $PATH, so one has to specify the full path for the pipe commands... Nah, that's not so good in my opinion. You should be able to use the same command that you would type at your shell prompt. > And how should we proceed with the interface? > Again, for me it's already enough as it is now... configurable for often > used / complicated commands and still working for new ones directly > specified as output file... I think it's okay so far. If somebody suggests a better way, we can still change it. > I play arround a bit with QT-designer (see attached picture), creating an > export dialog for pipe commands, but I'm not convinced if that would be the > best solution (beside the fact that I don't know at the moment how to > integrate the new ui into the rest of the code... technically & logically). Please let's defer that. I don't feel like fiddling with that stupid designer at the moment. > Another option would be just to stick with the current export dialog (with > pipes integrated) and implement a proper Settings-Menu, which we need > anyow and then (among other stuff) also allows to edit / configure the pipes! Since we have so many settings already, it's about time to build a configuration dialog. > BTW,... > > dvbcut -batch -exp "|dvdauthor -t -o dvd -" recording.ts; dvdauthor -o dvd -T > > is also a nice option which I just realized that is working now (of > course) ... ;-) Yeah, of course. > But we need a -format switch to select the output type... guess that fit's > into my above mentioned CLI-patch! ;-) Okay... but that should not change the current settings. >>I just changed the settings file format a little, therefore everybody >>who is using Ralph's patch should adapt his settings file: >> >> /pipe/0-command >> >>becomes >> >> /pipe/0/command >> >>and so on. > > > OK, doesn't matters for me... just a question... > Should I implement something similar for the recentfiles? > > At the moment I have implemented: > > recentfiles/0=/tmp/topf/test.rec_01 > recentfiles/0-001=/tmp/topf/test.rec_02 > recentfiles/0-idx=/tmp/topf/test.rec.idx > > to be backward compatible with the current scheme! > > But we could also have something like: > > recentfiles/0/0=/tmp/topf/test.rec_01 > recentfiles/0/1=/tmp/topf/test.rec_02 > recentfiles/0/idx=/tmp/topf/test.rec.idx > > and break with the current format! I think that would be the best way to do it. By the way: You should also add the name of the bookmark (*.app?) file if there is one. -- Michael "Tired" Riepe <[EMAIL PROTECTED]> X-Tired: Each morning I get up I die a little ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ DVBCUT-user mailing list DVBCUT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dvbcut-user
