Hi! David Timms wrote: > Hi, I'm not sure whether these two patches would be acceptable as is, or > whether they would need more work. > > Basically, with the newer autoconf build process, we have needed these > hacks to properly configure dvbcut for external ffmpeg, and for make > install to use a useful installroot. > > Also, it seems pretty standard, on lot's of project sources, to be able > at the install stage to be able to do: > make install DESTDIR=%{buildroot}
No big problem to add that. > However, this doesn't seem possible/doesn't work with dvbcut. My method > involved running ./configure (again) in the install stage, appending the > --prefix: > ==== > ./configure --libdir=%{_libdir} --with-ffmpeg=%{_prefix} \ > LDFLAGS="-L $QTDIR/lib" --prefix=%{buildroot}%{_prefix} > > make install > ==== > A colleague improved upon that to: > make install \ > bindir=%{buildroot}%{_bindir} \ > mandir=%{buildroot}%{_mandir} > ===== Yep, that's the usual way to fool GNU-style Makefiles. > Anyway, I thought I would make the suggestion in any case... > > David Timms. > > > ------------------------------------------------------------------------ > > --- configure.in.orig 2009-01-01 00:53:06.000000000 +1100 > +++ configure.in 2009-01-01 00:53:12.000000000 +1100 > @@ -149,7 +149,7 @@ > AC_SUBST(QTDIR) > > CPPFLAGS="$CPPFLAGS -I$QTDIR/include/qt3 -I$QTDIR/include" > -LDFLAGS="$LDFLAGS -L$QTDIR/$mr_libdirname" > +LDFLAGS="$LDFLAGS -L$QTDIR/lib" Uh... do people really install 64-bit Qt libraries in $QTDIR/lib? That can get really funny if you have a biarch (e.g. i686/x86_64) system. I'd rather add another option (--with-qt3-libs or something like that) to override the default. > AC_CHECK_LIB(qt-mt, main, > [LIBS="$LIBS -lqt-mt"], > > > ------------------------------------------------------------------------ > > --- src/Makefile.in.orig 2009-01-01 01:07:04.000000000 +1100 > +++ src/Makefile.in 2009-01-01 00:59:38.000000000 +1100 > @@ -102,7 +102,7 @@ > > $(topdir)/bin/dvbcut$(EXEEXT): dvbcut$(EXEEXT) > $(INSTALL_PROGRAM) dvbcut$(EXEEXT) $(topdir)/bin/dvbcut$(EXEEXT) > - $(STRIP) $(topdir)/bin/dvbcut$(EXEEXT) > + That's easy to circumvent: "make STRIP=: all install" I originally added this for the Windows port - I didn't want to generate MSI installers from unstripped binaries. On Linux/Unix, we can as well install the unstripped version from $(topdir)/src (and override INSTALL_PROGRAM on the fly). -- Michael "Tired" Riepe <mich...@mr511.de> X-Tired: Each morning I get up I die a little ------------------------------------------------------------------------------ _______________________________________________ DVBCUT-user mailing list DVBCUT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dvbcut-user