Michael Olson <[EMAIL PROTECTED]> writes:

> * lisp/bzr.el (bzr-ignore-setup): Call dvc-make-temp-dir.  If "bzr init;
>   bzr ignored" fails to make the file, make it ourselves.  There's no
>   need to throw a confusing warning message here.

Yes there is.

bzr creates the file with a default content. If you create the file
yourself, then after upgrading bzr, you will not get the default
content (=> in particular, you'll not get *~, *.o & so ignored by
default). I believe it's worth a warning.

Anyway, what's the point in creating the file : if it hasn't been
created, it means you have a version of bzr which doesn't manage it.
The problem will be resolved when you upgrade bzr.

Otherwise, the patch seems OK, thanks,

-- 
Matthieu

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to