Christian Ohler <[EMAIL PROTECTED]> writes:

> Stephen Leake, 2007-04-09:
>
>> The patch below allows 'shortcuts' with dvc-status :
>> (dvc-status nil "/Gnu/dvc")
>> I use these in text files to easily run dvc on various trees;
>> evaluate
>> with C-x C-e. bzr-status already takes a path argument. I did not
>> examine the other backends.
>
> With this reasoning, you'd also have to add a "root" argument to
> dvc-missing, dvc-pull and dvc-update, because they have very similar
> use cases.  For reasons of symmetry, you'd then have to add a "root"
> argument to every interactive DVC command.

Right.

> Maybe this is the right way to go; but I'm not convinced by this use
> case.  Since this is code that you have a text file anyway (as opposed
> to typing it every time), you could just as well write (let
> ((default-directory "/Gnu/dvc")) (dvc-status)).

Good point. I hadn't thought of that.

Currently, with pcl-cvs, shortcuts look like:

(cvs-examine "/Gnu/dvc" nil)

So I wanted something similar.

> Also, if we want to introduce a "root" argument, it should be the
> first argument, not the second.  (And it should be named "root", not
> "path".)

"path" was already used in bzr-dvc-status. Otherwise "root" makes more
sense.

>> -;; FIXME: I don't know what AGAINST is for.
>> +;; FIXME: use AGAINST
>>  ;;;###autoload
>> -(defun xmtn-dvc-status (&optional against)
>> +(defun xmtn-dvc-status (&optional against path)
>> +  "run monotone inventory on optional PATH (default current tree), display 
>> results.
>> +
>> +AGAINST must be a revision specifier (number, last:N,
>> +revid:foobar, ...) or nil, but is currently not used."
>
> What's a "revision specifier"?  

See docs/DVC-API, "Revision API".

> It looks like a bzr thing. "number" and "last:N" don't make much
> sense for monotone.

Right. I found this comment on what "AGAINST" meant in the bzr code,
and just copied it. That was before I found docs/DVC-API :(.

> In what situations would it be useful to run dvc-status against a
> revision other than the workspace base revision?

I was wondering that myself. There doesn't seem to be a way to set
'against' in the dvc user interface, but maybe I just haven't found it
yet.

After I get used to how dvc/monotone/bzr work, I'll make a stab at
updating the user manual, with info like this.

-- 
-- Stephe

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to