dvc-build-dvc-command screws up the xmtn-tests unit tests on Windows,
because the user temp directory name has spaces in it. (Yes, I know -
I should get a real OS :). I've got Cygwin installed, which is where
'sh' comes from. MinGW 'sh', gives the same errors. I'm using the
Windows monotone binary distribution.

Here's the function:

(defun dvc-build-dvc-command (dvc list-args)
  "Build a shell command to run DVC with args LIST-ARGS.
DVC can be one of 'baz, 'xhg, ..."
  (let* ((executable (dvc-variable dvc "executable"))
         (cmd (mapconcat 'shell-quote-argument
                         (cons executable
                               (delq nil list-args))
                         " ")))
    (when (eq system-type 'windows-nt)
       (setq cmd (replace-regexp-in-string "\\\"" "" cmd)))
    cmd))

If I comment out the (when windows-nt ...) part, the unit tests work
fine. That part seems quite odd; it is undoing the quoting that was
just done.

Why was it put in?

-- 
-- Stephe

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to