Matthieu Moy <[EMAIL PROTECTED]> writes:

> Stephen Leake <[EMAIL PROTECTED]> writes:
>
>> I can run Christian's xmtn-tests.el on Windows; they all pass except
>> two that deal with non-ascii stuff. I'll leave fixing those for later;
>> I've never tried to deal with non-ascii encodings.
>>
>> I highly recommend writing tests like this; it makes changing code
>> much less dangerous.
>
> Indeed, I wrote a test framework for Xtla a loong time ago. It's still
> tla-tests.el, but while the framework itself it not too bad, nobody
> started actually using it. Then I also became too lazy :-(.

Ah; I missed that. Perhaps we should move it into the dvc/lisp/tests
directory; that will make it more obvious to the next developer.

>>        (sleep-for 2); let log display
>
> I'm not sure what's the difference, but I usually use `sit-for' for
> that purpose, and I don' think it has this problem.

That works. Thanks.

>
>
> For example, tla-tests.el has:
>
> (defun tla-tests-wait-end-of-process ()
>   "Waits for all asynchronous tla processes to terminate."
>   (while dvc-process-running
>     (message "Processes: %s" dvc-process-running)
>     (sit-for 0.2)))

Excellent. This could be 'dvc-tests-wait-async-complete'; perhaps we
need a dvc-tests-utils.el.

I'll look thru tla-test.el for other good ideas.

-- 
-- Stephe

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to