Stephen Leake, 2007-07-08: > xmtn--add-patterns-to-mtnignore calls xmtn--file-registered-p each > time it is executed. On my machine, this is noticeably slow (several > tens of seconds).
In the mtn-has-basic-io-inventory case, it should be possible to speed this up somewhat by passing the file name we're looking for to mtn automate inventory. This will avoid generating the entire inventory. But as you say below, the check can be removed entirely. > .mtn-ignore will show up the next time the user does dvc-status or > dvc-diff, so I don't think it's necessary to call > xmtn--file-registered-p. It shows up in dvc-status, yes, but not in dvc-diff. The question seemed useful to me when xmtn had no reasonable implementation of dvc-status since I tended to forget adding .mtn-ignore. But given that xmtn will have a reasonable implementation of dvc-status as soon as mtn's basic-io inventory branch gets merged, we can remove the question, yes, and never add the file to the manifest from any of the 'ignore' commands. Christian. _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
