When building DVC using "make", errors while byte-compiling .el files
are printed to the terminal but don't affect the return value of the
"make" command. The messages just scroll by and are easy to miss; the
build will look successful. (I think the "Variable binding depth
exceeds max-specpdl-size" issue that Sam Steingold reported on
2007-07-09 was an instance of this.)
I'd prefer if "make" aborts on the first error encountered. The
following patch implements this. But it seems suspicious to me that the
author of that code appears to have gone out of his way to do the
opposite -- the invocation of `byte-compile-file' is wrapped in an
`ignore-errors' form. Anyone know what's going on?
Christian.
--- lisp/contrib/package-maint.el 2007-04-11 19:17:02 +0000
+++ lisp/contrib/package-maint.el 2007-07-18 23:14:08 +0000
@@ -336,8 +336,9 @@
(unless warn
(setq byte-compile-warnings package-maint-compile-warnings))
(when (package-maint-changed-source-p file)
- (ignore-errors
- (byte-compile-file (expand-file-name file srcdir)))))
+ (let ((successp (byte-compile-file (expand-file-name file srcdir))))
+ (unless successp
+ (error "Error(s) compiling %s" file)))))
(defun package-maint-compile-verbosely ()
"Call package-maint-compile with warnings ENABLED. If you are compiling
_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev
