Stephen Leake <[EMAIL PROTECTED]> writes:
> In pcvs, when you request an ediff display of a file against its base
> version, the base is in the top window, the workspace in the bottom.
>
> In DVC, the base is in the bottom.
>
> I find this confusing, and I think it will confuse new users.
>
> I guess tla followed the DVC convention?
>
> I'd like to change it to be the same as pcvs. Perhaps it needs to be a
> user option?
I found the required change. In dvc-diff.el, function dvc-diff-ediff
does:
(dvc-file-ediff-revisions on-modified-file
dvc-diff-modified
dvc-diff-base)
But dvc-file-ediff-revisions is defined as:
(defun dvc-file-ediff-revisions (file &optional base modified)
Another function, dvc-file-ediff, puts the base revision on top.
So it would seem the current behavior is a mistake, and dvc-diff-ediff
should be changed to do:
(dvc-file-ediff-revisions on-modified-file
dvc-diff-base
dvc-diff-modified)
Any objections?
--
-- Stephe
_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev
