Stefan Reichör <[EMAIL PROTECTED]> writes: > Stephen Leake <[EMAIL PROTECTED]> writes: > >> I would like to add dvc-log to dvc-back-end-wrappers, to allow >> specifying either bzr or xmtn back-end for dvc-log. >> >> However, xgit-log and xhg-log take significantly different arguments >> than dvc-log, so they would have to be renamed. >> >> One alternative is to just declare xmtn-log directly, with the same >> definition that dvc-back-end-wrappers would provide. >> >> The latter approach means dvc-log is not as unified as other dvc >> commands. > > We have traditionally a dvc-log and a dvc-changelog function. > > dvc-log is the common wrapper. dvc-changelog often provides a faster > implementation. > > Would it help to use dvc-changelog instead?
Hmm. For dvc-changelog, there is not the problem of different argument lists in the backends. So it could be unified easily. However, in bzr and xmtn, the only difference between dvc-log and dvc-changelog is that dvc-log shows only the first line of commit messages, while dvc-changelog shows the entire commit message. I prefer to start with the short log, and then view the full log only if necessary. I've just implemented a toggle in log buffers for that, so only one of dvc-log or dvc-changelog is needed for those back-ends. I'd rather keep dvc-log. Or change dvc-changelog to start with the short log message (which makes sense if it's supposed to be faster). But the main issue I'm concerned with is how clean the DVC code should be, and whether we want to change the back-ends to fit the new dvc-back-end-wrappers style. -- -- Stephe _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
