Stephen Leake <[EMAIL PROTECTED]> writes: > Stefan Reichör <[EMAIL PROTECTED]> writes: > >> Merged from Michael Olson: Various small fixes > > One change in this commit was to dvc-current-file-list, giving > priority to dvc-buffer-marked-file-list, which is what the doc string > says. > > I don't have any objection, but I'd like to understand the rationale. > Eventually, I'd like to replace dvc-buffer-marked-file-list with > dvc-fileinfo-marked-elems, so I'd like to understand all the cases > where dvc-buffer-marked-file-list is used. > > What was the use-case that prompted this change?
The use case is as follows. The xgit-status buffer uses its own mode
derived from dvc-diff-mode. Marked files in that buffer were not being
detected, so the quick fix was to make `dvc-current-file-list' check for
mode derived from 'dvc-diff-mode, rather than eq to it. If something
ought to take priority, then it should be placed higher in the cond
condition list.
--
Michael Olson -- FSF Associate Member #652 |
http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net | /` |\ | | |
Programmer -- Hobbies: Lisp, HCoop | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
pgpxFopA9rDRR.pgp
Description: PGP signature
_______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
