Stephen Leake <[EMAIL PROTECTED]> writes: > Stefan Reichör <[EMAIL PROTECTED]> writes: > >> Committed revision 517 to http://bzr.xsteve.at/dvc/ >> >> Implemented xgit-branch > > In dvc-unified.el, you didn't use define-dvc-unified-command for > dvc-*-branch. What is the rationale for this?
I am not sure, if we can use the same parameter list for all backends. dvc-* commands are normally not used for elisp scripting. They are used to invoke a command and DVC ensures that the correct backend is involved. The way I implemented it now, allows to have different parameters for each backend. I didn't look at other backends in detail, so I don't know if this is really needed. > The comment in dvc-unified.el for dvc-select-branch is not clear. What > does "select" mean, in terms of what happens to the current workspace? In git select just switches to a different view (called branch) in the current directory. I guess that every backend that supports branches allow to select a different branch. Selecting a branch should present a list of branches and the user should be able to pick one of them. > The comment for dvc-create-branch doesn't say what the parent branch > is. I don't know how a user would select a parent branch. When the parent branch (it is called start-point in my git documentation) is unknown, git uses a reasonable default. > In xgit.el, xgit-branch takes an argument giving the new branch name, > but dvc-create-branch takes no argument. Normally, we try to put all > argument processing in the dvc front-end, so the user interface is > more consistent across back-ends. As I said above, when we find compatible parameters for all our backends, we should use them. If not, my approach allows to use different parameters for each backend. > Apparently the branch is created with the current branch of the > current working directory as parent. In some cases, the user might > want to specify a different parent branch. Do we want to require them > to have that branch checked out? > > Does xgit-checkout change the branch of the current working directory? > Does it preserve any uncommitted changes? I don't know. > How do I checkout a branch into a new working directory? I guess you need to clone it to a different working directory. As far as I understood git branching, all takes place in the same working directory. > xgit-branch-list takes an 'all' argument. What branches are left out > if "all" is not specified? It omits remote-tracking branches. But I have no idea how remote-tracking branches are used... > The 'all' option should be promoted to an argument to > dvc-list-branches. mtn has a way to "suspend" a branch, so it no > longer shows up in the branch list. The option --ignore-suspend-certs > overrides that, so it would make sense to specify that option for > "all". This seems reasonable. Stefan. _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
