On Fri, Jan 05, 2007 at 09:50:39PM +0100, Anselm R. Garbe wrote: > On Fri, Jan 05, 2007 at 05:15:36PM +0100, Szabolcs Nagy wrote: > > On 1/5/07, Anselm R. Garbe <[EMAIL PROTECTED]> wrote: > > >On Fri, Jan 05, 2007 at 03:58:47PM +0100, Szabolcs Nagy wrote: > > >> why do you swap with memory copy (in view.c/swap())? > > >> why just changing the pointers (prev, next) not enough? > > > > > >The reason is that clients, stack or sel might be affected > > > > hmm maybe snext need to be swapped as well then? (otherwise c where > > c->snext==NULL can get to stack top and deataching it would cause > > problem) > > Yea that's true indeed. Could have been the reason. However, I > agree that current swap() sucks... Maybe a general pop() for any > client on zoom is better, at least it would be simplier.
Well I pushed several changesets which behave like dwm-2.8 for the first master client, all other clients are pop()'ed even if they also appear as master clients (this allows easy re-organization). Feels rather well and is much simplier (approx. -30 LOC) - and without this swap() insanity. Regards, -- Anselm R. Garbe >< http://suckless.org/~arg/ >< GPG key: 0D73F361
